Re: Please review wip/polarssl

[Thomas Klausner <thomasklausner%users.sourceforge.net@localhost>]

On Thu, Aug 09, 2012 at 11:32:40PM +0200, Moritz Wilhelmy wrote:
> I made good progress on polarssl during the last week (see CVS history),
> would someone please be kind enough to review it?

PKGNAME=                ${DISTNAME:-gpl=}
it's ok, but more common is
PKGNAME=                ${DISTNAME:S/-gpl//}

WRKSRC=                 ${WRKDIR}/${DISTNAME:-gpl=}
use
WRKSRC=                 ${WRKDIR}/${PKGNAME_NOREV}
instead.

pkglint complains that the patches have no comments.
 Thomas

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review