Re: Please review wip/muttprint

[Mayuresh <mayuresh%acm.org@localhost>]

On Fri, Mar 16, 2012 at 06:52:46PM +0100, Thomas Klausner wrote:
> > - I have not added latex as a dependency since there are various
> >   distributions. I have hence included a message regarding the same.
> 
> Well, no. It's a mixture. Pkgsrc is migrating to texlive, but as long
> as it's not fully there, the remaining parts come from the teTeX
> distribution.
> 
> Please add the missing dependencies that muttprint needs.

I, for one, install texlive outside of pkg system. As I already had the
DVD, didn't want to spend time building pkgsrc latex. Not sure whether it
is possible to avoid building latex by detecting my installation as it
won't be registered in pkg database.

> 
> > - The program muttprint-langinfo is probably not required. Not sure.
> >   Package Makfile and PLIST may be patched accordingly.
> 
> I can't say -- what does it do?

Following is what the INSTALL file says:

   Run "make" to build the small C program ("muttprint-langinfo"). You 
   need this only if your Perl version is less than 5.8.x.  If you have no
C
   compiler and you run Linux then you can skip this step, too.

But the makefile builds it by default. Since we take perl as a dependency,
shall we drop building of this program altogether?

> 
> > - There were makefiles in doc directories that gave an error regarding
> >   *.css not found. There were no css files in the sources. So I just
> >   removed those actions.
> 
> Upstream probably forgot including the files in the tarball. Please
> ask them about it.
> 
> > - There is a bug that causes "cannot remove path when cwd is
> >   /tmp/muttprint" error. A patch to cd the cwd to ~ is discussed on some
> >   mailing lists. Have adopted the same.
> 
> The patch looks weird :)

Agree.

> Is there an official upstream commit for this?

I'll try to communicate with upstream on both the patches and langinfo
issue. I'll make all required changes after waiting for a response for a
while.

Mayuresh

------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review