pkgsrc-WIP-review archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Please review wip/mp3blaster


From: "OBATA Akio" <>, Date: Mon, 10 Jan 
2011 22:21:20 +0900

> Hi,
> On Mon, 10 Jan 2011 20:06:17 +0900, Ryo ONODERA 
> <> wrote:
>> Please review it.
> MAKE_JOBS_SAFE=yes is default value, so redundant.

I see.
I removed this line.

> How about dependency on curses?
> I feel that it is still required (no need to be ncurses though).

The dependency on curses is sufficient.
I have tested on NetBSD/i386 current, DragonFly 2.8.2,
and Gentoo Linux (kernel 2.3.26). And works properly.

Please review again.

PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3

Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
pkgsrc-wip-review mailing list

Home | Main Index | Thread Index | Old Index