Re: Please review wip/fop

[Thomas Klausner <thomasklausner%users.sourceforge.net@localhost>]

On Tue, Jan 11, 2011 at 10:43:45PM +0100, Francois Tigeot wrote:
> It's only a packaging of the binary tarball from the ASF. It really 
> should be named fop-bin but I didnt want to have a different name from 
> the old package in textproc/
> 
> There's no need to run java to install it.

The name is fine.
Please set the LICENSE.
Also it would be nice if bin/fop already set the JAVA_HOME environment
variable correctly. In my environment I get
        Error: JAVA_HOME is not defined correctly.
          We cannot execute java
unless I run "JAVA_HOME=/usr/pkg/java/openjdk7 fop".

I also fixed some minor issues.
(Fix WRKSRC to use PKGNAME_NOREV; put option handling completely into
options.mk; remove unnecessary inclusion of bsd.prefs.mk.)

Cheers,
 Thomas

------------------------------------------------------------------------------
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review