pkgsrc-WIP-review archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Please review logrotate



On Thu, 04 Nov 2010 01:35:41 +0900, Nils Ratusznik 
<nils.sf.net%anotherhomepage.org@localhost> wrote:

> I updated wip/logrotate to 3.7.9. Could you please review it?

I cannot fetch DISTFILES, so just look at package's Makefile.

1. ${PKG_SYSCONFDIR} != ${PREFIX}/etc, for SUBST_*.confs.
2. and etc/logrotate.d also, maybe not in ${PREFIX}.
3. you can use `SUBST_VARS.*= PREFIX' instead of `SUBST_SED.*'
    if using `@PREFIX@' instead of `__PREFI__'.

-- 
OBATA Akio / obache%users.sourceforge.net@localhost

------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
Spend less time writing and  rewriting code and more time creating great
experiences on the web. Be a part of the beta today
http://p.sf.net/sfu/msIE9-sfdev2dev
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review


Home | Main Index | Thread Index | Old Index