Re: Please review umefont-ttf package.

[Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost>]

Thanks for your review.

>> Hi,
> 
>> Please review wip/umefont-ttf and send me comments.
>> It is my first font package.
> 
> 0 umefont-ttf>pkglint -Wall                                                   
>           
> NOTE: Makefile:16: Alignment of variable values should be done with tabs, not 
> spaces.
> NOTE: Makefile:17: Alignment of variable values should be done with tabs, not 
> spaces.
> NOTE: Makefile:18: Alignment of variable values should be done with tabs, not 
> spaces.
> WARN: Makefile:50: FONTS_DIRS.ttf may not be used in this file.
> WARN: Makefile:50: Please use ${FONTS_DIRS.ttf:Q} instead of 
> ${FONTS_DIRS.ttf}.
> 0 errors and 2 warnings found.
> 0 umefont-ttf>

I have no experience to use "pkglint -Wall" command.
It's great.

> It makes sense to fix tabs vs. spaces warnings,
> maybe others too.

Unintentionally, some tabs are replace by spaces.
Already fixed.

> Minor note: why not derive version in PKGNAME from DISTNAME?
> In this case version number should be specified only once.
> 
> Ex:
> --- Makefile    24 Dec 2009 13:40:31 -0000      1.2
> +++ Makefile    24 Dec 2009 23:24:45 -0000
> @@ -2,7 +2,7 @@
>  #
>  
>  DISTNAME=      umefont-410
> -PKGNAME=       umefont-0.410
> +PKGNAME=       ${DISTNAME:S/-/-0./}
>  CATEGORIES=    fonts japanese
>  MASTER_SITES=  ${MASTER_SITE_SOURCEFORGE_JP:=ume-font/22212/}

Thank you.
I used your patch.

> -- 
> Best regards, Aleksey Cheusov.

--
Ryo ONODERA // ryo_on%yk.rim.or.jp@localhost
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3



------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review