Re: wip/softhsm & wip/opendnssec

[Thomas Klausner <thomasklausner%users.sourceforge.net@localhost>]

On Thu, Oct 01, 2009 at 08:21:22AM +0200, Fredrik Pettai wrote:
> Those packages are not completely done yet,
> but any feedback now are welcome anyway...

softhsm:

pkglint is complaining:
NOTE: distinfo:2: Trailing empty lines.
WARN: distinfo: This file should not exist if NO_CHECKSUM or META_PACKAGE is 
set.
WARN: Makefile:19: SVN_REPOSITORIES is defined but not used. Spelling mistake?
WARN: Makefile:20: SVN_ROOT.softhsm is defined but not used. Spelling mistake?
WARN: Makefile:21: SVN_MODULE.softhsm is defined but not used. Spelling mistake?
WARN: Makefile:38: PLIST_OPSYS should be set to YES or yes.
WARN: Makefile:40: PLIST_SHLIB should be set to YES or yes.
WARN: Makefile:42: PLIST_SHLIB should be set to YES or yes.
WARN: PLIST.common:4: Redundant library found. The libtool library is
in line 3.
0 errors and 8 warnings found.

Ignore the three about spelling mistakes, but please fix the others :)

I think that you can get rid of the special OPSYS PLISTs; the libtool
code should handle them automatically.

The LICENSE looks like MIT to me, I'm not sure we need a separate one
for this.

opendnssec:
{BUILD_,}DEPENDS needs a version number; you can use "-[0-9]*" if you
don't care. In your examples:
DEPENDS+=       ${PYPKGPREFIX}-4Suite-[0-9]*:../../wip/py-4Suite
or
DEPENDS+=       ${PYPKGPREFIX}-4Suite>=1.2.3:../../wip/py-4Suite
(also in options.mk)

I think you can skip ${PREFIX} in INSTALLATION_DIRS.

options.mk: Do you need CONFIGURE_ARGS+=--disable-softhsm? Otherwise,
just test for !empty instead of empty.

Cheers,
 Thomas

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review