Re: cfengine3 pkg

[matthew sporleder <msporleder%gmail.com@localhost>]

On Fri, Aug 7, 2009 at 6:58 PM, Thomas
Klausner<thomasklausner%users.sourceforge.net@localhost> wrote:
> On Sun, Aug 02, 2009 at 01:10:39PM -0400, matthew sporleder wrote:
>> Hey, guys.  I whipped up a simple cfengine3 package but it's less
>> sophisticated than the cfengine(2) pkg that's already in wip.  The
>> upgrade is pretty major so I thought it was appropriate to add a new
>> package.
>>
>> Any comments or definite things to do on this one?
>
> Looks good in general, some nits:
> . pkglint has two complaints.
> . Does the "b" in the DISTNAME stand for "beta"? Then this should be
> made explicit, e.g. PKGNAME=${DISTNAME:S/b/beta/}

I don't know if the b is meaningful or not.

> . DESCR could be more verbose (see cfengine)
> . "cfengine is a" in COMMENT is redundant
> . you can remove the url2pkg-marker now...
>
> I haven't ever used cfengine, so I can't comment on if it works or if
> it's useful :)
>  Thomas
>

The /var/ thing is interesting.  In cfengine they call it "the
cfengine trusted work directory" where you put the copies of the files
you know work and that won't get overwritten when something else
happens.  I'll just have to work out every file that should be copied
over (if it doesn't already exist) and put it in there.

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review