Re: New Package: spawnfcgi

["Volkmar Seifert" <vs%nifelheim.info@localhost>]

Hi,

thanks for the review, I have just uploaded the adjusted Makefile and
PLIST to reflect your hints.


> If easily possible, please set LICENSE.

That's a little hard, as I cannot find a clear license-statement for
spawnfcgi, so I simply left it out, using the www/lighttpd pkg as an
example. Both projects have the same origin, and I guess the same license.
What looks most like a license to me is the COPYING file. It reads a bit
like the BSD-license, but in a very "customized" style.


> Installation gives me:
> install: /scratch/wip/spawnfcgi/work/spawn-fcgi-1.6.2/ChangeLog: stat: No
> such file or directory
> But it's not in the PLIST anyway :)

Yes, sorry, my mistake, there is no ChangeLog contained in the
spawn-fcgi-archive :)


> The PLIST is missing a "@dirrm share/doc/spawn-fcgi" at the end.

Not anymore :)


> Why is
> CONFIGURE_ARGS+= --libdir=${PREFIX}/lib/${PKGBASE}
> needed?

Another copy/paste-mistake I fear...I have removed the line, it is
superflous indeed.


> You can remove the EGDIR and its uses, it doesn't seem you need it.

Done.

I am awaiting further comments :)

best regards,

Volkmar

-- 
http://blog.nifelheim.info/tech

------------------------------------------------------------------------------
The NEW KODAK i700 Series Scanners deliver under ANY circumstances! Your
production scanning environment may not be a perfect world - but thanks to
Kodak, there's a perfect scanner to get the job done! With the NEW KODAK i700
Series Scanner you'll get full speed at 300 dpi even with all image 
processing features enabled. http://p.sf.net/sfu/kodak-com
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review