Re: wip/dvtm - ready for reviews

["OBATA Akio" <obata%lins.jp@localhost>]

On Sun, 02 Mar 2008 22:26:04 +0900, Leonardo Taccari 
<leonardo1990%gmail.com@localhost> wrote:

> Hello to all pkgsrc-wip developers,
> wip/dvtm package is ready for reviews. This is my first package but I
> hope there won't be any problems. If it's right I think that it can be
> imported into pkgsrc/misc.
>
>
> Thank you very much for suggestions and tips!

% pkglint -Wall
NOTE: Makefile:16: Alignment of variable values should be done with tabs, not 
spaces.
[and if no error occured, you may not define NO_CONFIGURE=yes,
  because some {pre,post}-configure target will not be called]
WARN: options.mk:6: PKG_LEGACY_OPTS is defined but not used. Spelling mistake?
[PKG_OPTIONS_LEGACY_OPT?]
WARN: patches/patch-aa:3: Comment expected.
[Why not patch to install target? It dose more works than your do-install 
target]

-- 
"Of course I love NetBSD":-)
OBATA Akio / obata%lins.jp@localhost


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review