pkgsrc-WIP-review archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: New package fdm. Ready for reviews.

On Sun, Feb 17, 2008 at 10:39:39PM +0900, OBATA Akio wrote:
> First, pkglint tell you some hints to do :-)
I was sure to ran pkglint before commit the package, probably
i confused with another package. Sorry! I've now run pkglint
and all warnings has been fixed. I ignored the unrecognized
option warnings about "pcre" which seems to be common among
pkgsrc packages. Maybe this option will be included into the
framework in further releases of pkgsrc.

> Second, you should honor PKGMANDIR (Makefile) and
> PKG_SYSCONFDIR (fdm.h and manual pages).
I fixed the Makefile by adding ${PKGMANDIR} between the list
of installation directories. Finally i used the substitution
framework in order to replace the static paths for all needed

> And you may need to add some tools to USE_TOOLS (yacc and ?).
Yes, you are right! I had not wanted at the whole Makefile
code, yet. Of course i did it now. We'll have a support to get
a list of tools ``that a package is using while being built'',
hopefully soon :-)

All the above things has been fixed (and committed). Thanks a
lot for your help and time.

Claudio M.

Version: 3.1
GCS/MU d-@ s: a--> C++(+++) UB++>$ P+> !L E--- W++(+++)
N+@ o--> K? w+@> O-@> M- V? PS+@ PE+@ Y+ PGP> t(-)@ 5?
X+ R? tv-- b+> DI-- D? G e+@> h--@> r y*

This email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
pkgsrc-wip-review mailing list

Home | Main Index | Thread Index | Old Index