Re: Request for review of wip/nx-client-bin

[Lubomir Kundrak <lkundrak%redhat.com@localhost>]

Hi Rumko,

On Sun, 2007-02-25 at 22:32 +0100, Rumko wrote:
> Hi!
> 
> nxclient is a NoMachine NX client for remote access. This package installs the
> official NX linux binary client.
> 
> Can someone please review it?

Thank you for this package, it came just when I needed it :)

I added a couple of missing dependencies and removed /dev/null from
PLIST. I think you should write a more descriptive DESCR, not a
COMMENT-like one-liner, which tells basically nothing.

Also, there's a RPM package of the program available. Is there a reason
why you you chose a tarball, not the RPM? I see many linux compat
packages are installed from RPM, which has an advantage of automatically
generating a PLIST, and... dunno what :) Does that package work with
SUSE?

Regards,
-- 
Lubomir Kundrak (Red Hat Security Response Team)


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review