pkgsrc-WIP-review archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: package for txt2tags



Hi!

On Tue, 11 Jul 2006 01:27:39 -0300, Daniel Bolgheroni wrote:
> I finished a new package for txt2tags. It's working fine, but I need a
> review. I think there is nothing else to do.

Why include python24/bl3.mk directly?
This package seems to be python application,
so you should include ../lang/python/application.mk instead,
and only works with python24, set
PYTHON_VERSIONS_ACCEPTED= 24

No need to use patch to replace shell bang (patch-aa).
use
PYTHON_PATCH_SCRIPTS = txt2tags

And do pkglint.

--
"Of course I love NetBSD":-)
OBATA Akio / obata%lins.jp@localhost



-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review



Home | Main Index | Thread Index | Old Index