On Mar 1, 2006, at 3:46 PM, Thomas Klausner wrote:
On Tue, Feb 28, 2006 at 10:34:53AM +0100, iMil wrote:please test and review wip/csupLooks good. Except for the comment, it shouldn't start with "A " (pkglint warns about this). Builds and installs/deinstalls fine.
Let me add a few.1. This package requires zlib and pthread in linking. Please add the corresponding buildlink3.mk files.
2. GNUmakefile contains hardcoded pthread options such as "- pthread". Use PTHREAD_* variables defined in mk/ pthread.buildlink3.mk instead.
3. The homepage URL shouldn't be in DESCR. Please move it to Makefile (HOMEPAGE).
Regards, Min Sik Kim ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 _______________________________________________ pkgsrc-wip-review mailing list pkgsrc-wip-review%lists.sourceforge.net@localhost https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review