{svn, cvs}-package.mk (Re: [PATCH] cache filename change for mk/git-package.mk

[Makoto Fujiwara <makoto%ki.nu@localhost>]

More than years ago, I'v written attached mail asking
cache-file name change for git-package.mk

Today, I've noticed wip/llvm and wip/clang use the different
name on the equivalent cache file (by svn-package.mk).

 20998854 Sep 28 20:04 distfiles/svn-packages/clang-llvm-2011-09-28.tar.gz
 20976690 Sep 28 17:22 distfiles/svn-packages/llvm-llvm-2011-09-28.tar.gz

I think we had better change the cache file name as like
git-package.mk.

Please give me the opinion, thanks a lot,
---
Makoto Fujiwara, 
Chiba, Japan, Narita Airport and Disneyland prefecture.

| From: Makoto Fujiwara <makoto%ki.nu@localhost>
| Subject: [PATCH] cache filename change for mk/git-package.mk
| Date: Wed, 28 Jul 2010 13:14:31 +0900
| Message-ID: <yfm1vaockew.wl%makoto%ki.nu@localhost>

mef> I found wip/emacs-current-nox11 was outdated.

mef>  While modifying it for git-package version, I thought
mef> following line of mk/git-package.mk is NOT appropriate (,which I wrote).

mef> | #   cache file name (compression is not really effective)
mef> | _GIT_DISTFILE.${_repo_}=  
${PKGBASE}-${GIT_MODULE.${_repo_}}-${_GIT_TAG.${_repo_}}.tar
mef> (This line is similar to mk/cvs-package.mk)

mef> This will make the cache file as 
mef> emacs-emacs-2010-07-27.tar 
mef>         for the emacs-current and
mef> emacs-nox11-emacs-2010-07-27.tar 
mef>    for the emacs-current-nox11.

mef> Meaning emacs-current and emacs-current-nox11 does NOT share the
mef> same git repository.

mef> But those two should be the same one.
mef> This is due to ${PKG_BASE} is different.

mef> So the change I would propose:

mef> (The impact of this change is that the name of cache files
mef> under distfiles/git-package/ will be different hereafter. Old
mef> saved (cached) files won't be used unless they are renamed
mef> manually .... but this should not be any serious.)

mef> If no objection in a few days, I would like to commit this, thanks.

mef> -_GIT_DISTFILE.${_repo_}=  
${PKGBASE}-${GIT_MODULE.${_repo_}}-${_GIT_TAG.${_repo_}}.tar
mef> +_GIT_DISTFILE.${_repo_}=  
${GIT_MODULE.${_repo_}}-${_GIT_TAG.${_repo_}}.tar

------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security
threats, fraudulent activity and more. Splunk takes this data and makes
sense of it. Business sense. IT sense. Common sense.
http://p.sf.net/sfu/splunk-d2dcopy1
_______________________________________________
pkgsrc-wip-discuss mailing list
pkgsrc-wip-discuss%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-discuss