Re: cvs-based WIP/ packages fail at extract stage under Linux

[Aleksey Cheusov <cheusov%tut.by@localhost>]

 >> --- cvs-package.mk  19 Sep 2008 21:19:27 -0000      1.27
 >> +++ cvs-package.mk  10 Oct 2008 17:35:12 -0000
 >> @@ -137,7 +137,7 @@
 >>  _CVS_TAG_FLAG.${r}=        -r${CVS_TAG}
 >>  _CVS_TAG.${r}=             ${CVS_TAG}
 >>  .  else
 >> -_CVS_TAG_FLAG.${r}=        -D${_CVS_TODAY}T00:00+0
 >> +_CVS_TAG_FLAG.${r}=        '-D${_CVS_TODAY} 00:00 +0000'
 >>  _CVS_TAG.${r}=             ${_CVS_TODAY:Q}
 >>  .  endif
 >>  _CVS_DISTFILE.${r}=        
 >> ${PKGBASE}-${CVS_MODULE.${r}}-${_CVS_TAG.${r}}.tar.gz
 >> @@ -171,7 +171,7 @@
 >>     ${STEP_MSG} "Downloading "${CVS_MODULE.${r}:Q}" from 
 >> "${CVS_ROOT.${r}:Q}"."; \
 >>     ${SETENV} ${_CVS_ENV}                                           \
 >>       ${_CVS_CMD} ${_CVS_FLAGS} -d ${CVS_ROOT.${r}:Q}               \
 >> -       checkout ${_CVS_CHECKOUT_FLAGS} ${_CVS_TAG_FLAG.${r}:Q}     \
 >> +       checkout ${_CVS_CHECKOUT_FLAGS} ${_CVS_TAG_FLAG.${r}}       \
 >>           -d ${r} ${CVS_MODULE.${r}:Q};                             \
 >>     ${STEP_MSG} "Creating cached CVS archive "${_CVS_DISTFILE.${r}:Q}"."; \
 >>     ${MKDIR} ${_CVS_DISTDIR:Q};                                     \

> :Q modifier may not be removed from _CVS_TAG_FLAG.${r}.
> It is also used for other than specifying TODAY.

To make things uniformed, I can quote -rTAG too.
But I don't see why _CVS_TAG_FLAG.${r} should be quoted.
According to CVS documentation:

       Tag names must start with an uppercase or lowercase letter and
       can contain uppercase and lowercase letters, digits, `-', and
       `_'

Neither of these symbols need quoting.

-- 
Best regards, Aleksey Cheusov.

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
pkgsrc-wip-discuss mailing list
pkgsrc-wip-discuss%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-discuss