chromium-wip: initial changes to support hid

To: pkgsrc-wip-changes%NetBSD.org@localhost
Subject: chromium-wip: initial changes to support hid
From: kikadf (via pkgsrc-wip) <commit-notify%pkgsrc.org@localhost>
Date: Wed, 13 Aug 2025 17:45:03 +0000
Module Name:	pkgsrc-wip
Committed By:	kikadf <kikadf.01%gmail.com@localhost>
Pushed By:	kikadf
Date:		Wed Aug 13 19:43:57 2025 +0200
Changeset:	2b4e85193f912aa5be84a2a507314948a52caa46

Modified Files:
	chromium-wip/Makefile
	chromium-wip/TODO
	chromium-wip/distinfo
	chromium-wip/options.mk
	chromium-wip/patches/patch-services_device_hid_BUILD.gn
	chromium-wip/patches/patch-services_device_hid_hid__service.cc
Removed Files:
	chromium-wip/COMMIT_MSG

Log Message:
chromium-wip: initial changes to support hid

To see a diff of this commit:
https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=commitdiff;h=2b4e85193f912aa5be84a2a507314948a52caa46

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

diffstat:
 chromium-wip/COMMIT_MSG                            | 22 --------------------
 chromium-wip/Makefile                              |  4 +++-
 chromium-wip/TODO                                  | 16 +--------------
 chromium-wip/distinfo                              |  4 ++--
 chromium-wip/options.mk                            |  2 +-
 .../patches/patch-services_device_hid_BUILD.gn     | 14 ++++++-------
 .../patch-services_device_hid_hid__service.cc      | 24 ++++------------------
 7 files changed, 18 insertions(+), 68 deletions(-)

diffs:
diff --git a/chromium-wip/COMMIT_MSG b/chromium-wip/COMMIT_MSG
deleted file mode 100644
index 4e95ca4acd..0000000000
--- a/chromium-wip/COMMIT_MSG
+++ /dev/null
@@ -1,22 +0,0 @@
-www/chromium: update to 139.0.7258.66
-
-* 139.0.7258.66
-This update includes 12 security fixes. Below, we highlight fixes
-that were contributed by external researchers. Please see the
-Chrome Security Page for more information.
-[$2000][414760982] Medium CVE-2025-8576: Use after free in Extensions.
-Reported by asnine on 2025-04-30
-[$1000][384050903] Medium CVE-2025-8577: Inappropriate implementation
-in Picture In Picture. Reported by Umar Farooq on 2024-12-14
-[TBD][423387026] Medium CVE-2025-8578: Use after free in Cast.
-Reported by Fayez on 2025-06-09
-[$10000][407791462] Low CVE-2025-8579: Inappropriate implementation in
-Gemini Live in Chrome. Reported by Alesandro Ortiz on 2025-04-02
-[$2000][411544197] Low CVE-2025-8580: Inappropriate implementation in
-Filesystems. Reported by Huuuuu on 2025-04-18
-[$2000][416942878] Low CVE-2025-8581: Inappropriate implementation in
-Extensions. Reported by Vincent Dragnea on 2025-05-11
-[$1000][40089450] Low CVE-2025-8582: Insufficient validation of
-untrusted input in DOM. Reported by Anonymous on 2017-10-31
-[$500][373794472] Low CVE-2025-8583: Inappropriate implementation in
-Permissions. Reported by Shaheen Fazim on 2024-10-16
diff --git a/chromium-wip/Makefile b/chromium-wip/Makefile
index 1c6703c783..09f827fd67 100644
--- a/chromium-wip/Makefile
+++ b/chromium-wip/Makefile
@@ -165,7 +165,7 @@ GN_ARGS+=	use_system_harfbuzz=true
 GN_ARGS+=	use_system_libdrm=true
 GN_ARGS+=	use_system_libjpeg=true #libjpeg-turbo
 GN_ARGS+=	use_thin_lto=false
-GN_ARGS+=	use_udev=false
+GN_ARGS+=	use_udev=true
 GN_ARGS+=	use_vaapi=false
 GN_ARGS+=	v8_enable_cet_ibt=true
 
@@ -370,4 +370,6 @@ BUILDLINK_TRANSFORM+=	l:pci:pciutils
 .include "../../x11/libXScrnSaver/buildlink3.mk"
 .include "../../x11/libXtst/buildlink3.mk"
 .include "../../x11/qt6-qtbase/buildlink3.mk"
+BUILDLINK_DEPMETHOD.libudev-bsd=	build
+.include "../../wip/libudev-bsd/buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"
diff --git a/chromium-wip/TODO b/chromium-wip/TODO
index e611a939c9..814ccf4d32 100644
--- a/chromium-wip/TODO
+++ b/chromium-wip/TODO
@@ -1,17 +1,3 @@
 To Do:
 
-0) Build on NetBSD-10 amd64
-
-1) Audio backends
- a) NetBSD uses sunaudio (https://github.com/kikadf/chromium-audioio)
- b) FreeBSD uses pulseaudio
-
-If pulseaudio not run, chromium can't start it, so no sound:
-VERBOSE1:pulse_util.cc(261)] Failed to connect to the context. Error: Connection refused
-WARNING:audio_manager_linux.cc(53)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized.
-
-If pulseaudio already started, chromium can join it, and has sound.
-This is the workaround, see the files/chromium.sh.in launch wrapper.
-
-2) HID doesn't work on NetBSD.
-NOTE: For this OpenBSD uses libudev-openbsd, FreeBSD uses devd.
+Make HID workable on NetBSD.
diff --git a/chromium-wip/distinfo b/chromium-wip/distinfo
index 6f8676ebaa..d333b2965c 100644
--- a/chromium-wip/distinfo
+++ b/chromium-wip/distinfo
@@ -1045,12 +1045,12 @@ SHA1 (patch-services_audio_audio__sandbox__hook__linux.cc) = 0c686037b82488891fd
 SHA1 (patch-services_audio_audio__sandbox__hook__linux.h) = d981e6a222debb41818015fd888ea5f9e8d04a28
 SHA1 (patch-services_device_BUILD.gn) = 33a6f01ee1108e6b7326b4065d94c50e602a980f
 SHA1 (patch-services_device_geolocation_location__provider__manager.cc) = 0bf628192a69f7cecc31b137540ad558de6a1bd1
-SHA1 (patch-services_device_hid_BUILD.gn) = d14d0caccca7048f47508adf1f88148fecd21b75
+SHA1 (patch-services_device_hid_BUILD.gn) = e693f728eb023312c13699ffabb3d6990e9d2034
 SHA1 (patch-services_device_hid_hid__connection__fido.cc) = e8ee4654144977a7778e204435ba19ef67cdce22
 SHA1 (patch-services_device_hid_hid__connection__fido.h) = 22565f987616b5031739b9fd8b3656068e4537ab
 SHA1 (patch-services_device_hid_hid__connection__freebsd.cc) = 5af8754728a958fe130086fb797bf3ebff6ee7fb
 SHA1 (patch-services_device_hid_hid__connection__freebsd.h) = b6f88864cc0cffba0af713678bfd054d4f51c2f6
-SHA1 (patch-services_device_hid_hid__service.cc) = f0d432536e8dcdc0d72ec294e46a155906ff3bb7
+SHA1 (patch-services_device_hid_hid__service.cc) = cdef0ed995c4e9b31f653124172e0648aa05ba51
 SHA1 (patch-services_device_hid_hid__service__fido.cc) = 78c8593e52835aae5e7d74b3d580265da89c3a4d
 SHA1 (patch-services_device_hid_hid__service__fido.h) = 4d2edb0f76e76f1ef294579e214b3771a3d7fe4e
 SHA1 (patch-services_device_hid_hid__service__freebsd.cc) = ef275d5c46f91f4ccbf705e9e6c0d17c7eaf702a
diff --git a/chromium-wip/options.mk b/chromium-wip/options.mk
index 87a2c28d09..851734d9da 100644
--- a/chromium-wip/options.mk
+++ b/chromium-wip/options.mk
@@ -6,7 +6,7 @@ PKG_OPTIONS_GROUP.audio=	alsa pulseaudio sunaudio
 PKG_SUPPORTED_OPTIONS+=		debug
 
 .if ${OPSYS} == "NetBSD"
-PKG_SUGGESTED_OPTIONS+=		sunaudio
+PKG_SUGGESTED_OPTIONS+=		sunaudio debug
 .else
 PKG_SUGGESTED_OPTIONS+=		pulseaudio
 .endif
diff --git a/chromium-wip/patches/patch-services_device_hid_BUILD.gn b/chromium-wip/patches/patch-services_device_hid_BUILD.gn
index f6605d9410..b89f716e72 100644
--- a/chromium-wip/patches/patch-services_device_hid_BUILD.gn
+++ b/chromium-wip/patches/patch-services_device_hid_BUILD.gn
@@ -11,7 +11,7 @@ $NetBSD$
    ]
  
 -  if ((is_linux || is_chromeos) && use_udev) {
-+  if (is_openbsd) {
++  if (is_openbsd || is_netbsd) {
 +    sources += [
 +      "hid_connection_fido.cc",
 +      "hid_connection_fido.h",
@@ -30,12 +30,12 @@ $NetBSD$
 +    ]
 +  }
 +
-+  if (is_netbsd) {
-+    sources += [
-+      "hid_service_netbsd.cc",
-+      "hid_service_netbsd.h",
-+    ]
-+  }
++#  if (is_netbsd) {
++#    sources += [
++#      "hid_service_netbsd.cc",
++#      "hid_service_netbsd.h",
++#    ]
++#  }
 +
 +  if ((is_linux || is_chromeos) && !is_bsd && use_udev) {
      sources += [
diff --git a/chromium-wip/patches/patch-services_device_hid_hid__service.cc b/chromium-wip/patches/patch-services_device_hid_hid__service.cc
index 50d2e30710..9c1cf082b4 100644
--- a/chromium-wip/patches/patch-services_device_hid_hid__service.cc
+++ b/chromium-wip/patches/patch-services_device_hid_hid__service.cc
@@ -6,41 +6,25 @@ $NetBSD$
 
 --- services/device/hid/hid_service.cc.orig	2025-07-29 22:51:44.000000000 +0000
 +++ services/device/hid/hid_service.cc
-@@ -20,12 +20,18 @@
+@@ -20,6 +20,10 @@
  
  #if (BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS)) && defined(USE_UDEV)
  #include "services/device/hid/hid_service_linux.h"
-+#elif BUILDFLAG(IS_OPENBSD)
++#elif BUILDFLAG(IS_OPENBSD) || BUILDFLAG(IS_NETBSD)
 +#include "services/device/hid/hid_service_fido.h"
 +#elif BUILDFLAG(IS_FREEBSD)
 +#include "services/device/hid/hid_service_freebsd.h"
  #elif BUILDFLAG(IS_MAC)
  #include "services/device/hid/hid_service_mac.h"
  #elif BUILDFLAG(IS_WIN)
- #include "services/device/hid/hid_service_win.h"
- #elif BUILDFLAG(IS_FUCHSIA)
- #include "services/device/hid/hid_service_fuchsia.h"
-+#elif BUILDFLAG(IS_NETBSD)
-+#include "services/device/hid/hid_service_netbsd.h"
- #endif
- 
- namespace device {
-@@ -68,12 +74,18 @@ constexpr base::TaskTraits HidService::k
+@@ -68,6 +72,10 @@ constexpr base::TaskTraits HidService::k
  std::unique_ptr<HidService> HidService::Create() {
  #if (BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS)) && defined(USE_UDEV)
    return std::make_unique<HidServiceLinux>();
-+#elif BUILDFLAG(IS_OPENBSD)
++#elif BUILDFLAG(IS_OPENBSD) || BUILDFLAG(IS_NETBSD)
 +  return std::make_unique<HidServiceFido>();
 +#elif BUILDFLAG(IS_FREEBSD)
 +  return std::make_unique<HidServiceFreeBSD>();
  #elif BUILDFLAG(IS_MAC)
    return std::make_unique<HidServiceMac>();
  #elif BUILDFLAG(IS_WIN)
-   return std::make_unique<HidServiceWin>();
- #elif BUILDFLAG(IS_FUCHSIA)
-   return std::make_unique<HidServiceFuchsia>();
-+#elif BUILDFLAG(IS_NETBSD)
-+  return std::make_unique<HidServiceNetBSD>();
- #else
-   return nullptr;
- #endif
Prev by Date: git-bug: adjust user/organization
Next by Date: Add chromium-wip to test hid services
Previous by Thread: git-bug: adjust user/organization
Next by Thread: Add chromium-wip to test hid services
Indexes:
Home | Main Index | Thread Index | Old Index