jitsi-meet: Resolve TODO about resource limits

[Greg Troxel (via pkgsrc-wip) <commit-notify%pkgsrc.org@localhost>]

Module Name:	pkgsrc-wip
Committed By:	Greg Troxel <gdt%lexort.com@localhost>
Pushed By:	gdt
Date:		Mon Mar 3 09:08:05 2025 -0500
Changeset:	68f6f5541ee9fffe2d2c184dd28ce7b2b9dfd6a3

Modified Files:
	jitsi-meet/Makefile
	jitsi-meet/TODO

Log Message:
jitsi-meet: Resolve TODO about resource limits

I built this on a machine with 12000 MB of RAM (yes, I know that's not
quite 12 GB), including WRKDIR on tmpfs, without issues and have noted
that in the Makefile.  But, with 6000 MB there was unacceptable
paging.  This package is therefore not unusual compared to many others
that won't build without lots of resources.

Adjust TODO:
  - note need to remediate google analytics
  - note that chat/jitsi-meet/Makefile.common should probably be split

To see a diff of this commit:
https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=commitdiff;h=68f6f5541ee9fffe2d2c184dd28ce7b2b9dfd6a3

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

diffstat:
 jitsi-meet/Makefile | 15 +++++++++++----
 jitsi-meet/TODO     | 18 +++++++++++++++---
 2 files changed, 26 insertions(+), 7 deletions(-)

diffs:
diff --git a/jitsi-meet/Makefile b/jitsi-meet/Makefile
index 41eb64105f..99d455d610 100644
--- a/jitsi-meet/Makefile
+++ b/jitsi-meet/Makefile
@@ -12,10 +12,9 @@ DISTINFO_FILE=         ${.CURDIR}/distinfo
 USE_LANGUAGES+=	c++
 USE_TOOLS+=	gmake tar
 
-TOOL_DEPENDS+=	nodejs>=18:../../lang/nodejs22
-
-BUILD_TARGET=	compile
-INSTALL_TARGET=	deploy source-package
+# While earlier node is not known to fail, it seems straightforward to
+# expect the current LTS or newer.
+TOOL_DEPENDS+=	nodejs>=22:../../lang/nodejs22
 
 EGDIR=			share/jitsi-meet
 PKG_SYSCONFSUBDIR=	jitsi/meet
@@ -24,6 +23,7 @@ CONF_FILES+=		${EGDIR}/interface_config.js \
 			${PKG_SYSCONFDIR}/interface_config.js
 CONF_FILES+=		${EGDIR}/title.html ${PKG_SYSCONFDIR}/title.html
 
+# \todo Explain how this variable makes its way into the package.
 BUILD_DEFS+=		VARBASE
 
 INSTALLATION_DIRS=	${EGDIR} share/examples/jitsi-meet
@@ -32,6 +32,13 @@ do-configure:
 	cd ${WRKSRC} && \
 		npm install
 
+# Running webpack takes a lot of RAM.  Building on a machine with 6000
+# MB, heavy paging resulted, and it wasn't clear that it would finish.
+# With 12000 MB, the package built without issues.
+BUILD_TARGET=	compile
+
+INSTALL_TARGET=	deploy source-package
+
 post-install:
 	${RUN} ${TAR} -C ${DESTDIR}${PREFIX}/share -xjf ${WRKSRC}/jitsi-meet.tar.bz2
 	${INSTALL_DATA} ${WRKSRC}/config.js \
diff --git a/jitsi-meet/TODO b/jitsi-meet/TODO
index 9398b629f4..455f5401a4 100644
--- a/jitsi-meet/TODO
+++ b/jitsi-meet/TODO
@@ -1,4 +1,16 @@
-- Place more configuration files in $SYSCONFDIR/jitsi-meet (branding.json...)
-- Provide installation instructions
+- Place more configuration files in $SYSCONFDIR/jitsi-meet
+  (branding.json...)
+
+- Excise google analytics, following pkgsrc's norm of removing
+  phone-home code.
+
+- Provide installation instructions.
+
 - No longer pull data from the network (see www/gitea)
-- Work around out of memory conditions (eg "ulimit -l $((`ulimit -l` * 2))")
+
+- Resolve chat/jitsi-meet/Makefile.common setting DISTINFO_FILE but
+  not PATCHDIR.  Makefile.common is partly for all jitsi-world
+  packages, and partly for things that use a specific distifile.
+  Perhaps that should be split into two fragments so that e.g. jicofo
+  would only include the larger-scope defines, and not have to undo
+  the jitsi-meet-specific settings.