rtl_433: Minor rototill (comment out old stuff)

[Greg Troxel (via pkgsrc-wip) <commit-notify%pkgsrc.org@localhost>]

Module Name:	pkgsrc-wip
Committed By:	Greg Troxel <gdt%lexort.com@localhost>
Pushed By:	gdt
Date:		Sun Oct 27 09:06:14 2024 -0400
Changeset:	77a1ef44645f140052cf8c1b33df286feed7fabb

Modified Files:
	rtl_433/Makefile

Log Message:
rtl_433: Minor rototill (comment out old stuff)

Comment out a number of things likely leftover from much older cmake
support.

Add comments that various things need fixing or justifying.

To see a diff of this commit:
https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=commitdiff;h=77a1ef44645f140052cf8c1b33df286feed7fabb

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

diffstat:
 rtl_433/Makefile | 31 ++++++++++++++++++++-----------
 1 file changed, 20 insertions(+), 11 deletions(-)

diffs:
diff --git a/rtl_433/Makefile b/rtl_433/Makefile
index 555dec86cc..26dd702402 100644
--- a/rtl_433/Makefile
+++ b/rtl_433/Makefile
@@ -2,7 +2,7 @@
 
 GITHUB_PROJECT=	rtl_433
 GITHUB_TAG=	23.11
-DISTNAME=	23.11
+DISTNAME=	${GITHUB_TAG}
 PKGNAME=	${GITHUB_PROJECT}-${DISTNAME}
 CATEGORIES=	ham
 MASTER_SITES=	${MASTER_SITE_GITHUB:=merbanan/}
@@ -19,33 +19,42 @@ USE_LANGUAGES=	c c++
 USE_TOOLS+=	pkg-config pax
 AUTO_MKDIRS=	yes
 
-CMAKE_CONFIGURE_ARGS+=	-Wno-dev
-CMAKE_CONFIGURE_ARGS+=	-DCMAKE_INSTALL_MANDIR=${PREFIX}/${PKGMANDIR}
-CMAKE_CONFIGURE_ARGS+=	-DCMAKE_BUILD_WITH_INSTALL_RPATH=TRUE
-CMAKE_CONFIGURE_ARGS+=	-DCMAKE_INSTALL_PREFIX=${PREFIX}
-CMAKE_CONFIGURE_ARGS+=	-DCMAKE_INSTALL_RPATH=${PREFIX}/lib
-CMAKE_CONFIGURE_ARGS+=	-DCMAKE_INSTALL_RPATH_USE_LINK_PATH=FALSE
+# \todo Remove or add a comment justifying.
+#CMAKE_CONFIGURE_ARGS+=	-Wno-dev
 
-CMAKE_ARG_PATH=		../
-CONFIGURE_DIRS=		build
+# \todo Remove or add a comment justifying.
+#CMAKE_CONFIGURE_ARGS+=	-DCMAKE_INSTALL_MANDIR=${PREFIX}/${PKGMANDIR}
+#CMAKE_CONFIGURE_ARGS+=	-DCMAKE_BUILD_WITH_INSTALL_RPATH=TRUE
+#CMAKE_CONFIGURE_ARGS+=	-DCMAKE_INSTALL_PREFIX=${PREFIX}
+#CMAKE_CONFIGURE_ARGS+=	-DCMAKE_INSTALL_RPATH=${PREFIX}/lib
+#CMAKE_CONFIGURE_ARGS+=	-DCMAKE_INSTALL_RPATH_USE_LINK_PATH=FALSE
+
+# \todo Remove or add a comment justifying.
+#CMAKE_ARG_PATH=		../
+#CONFIGURE_DIRS=		build
 
 PKG_SYSCONFSUBDIR=	rtl_433
+# missing CONF_FILES?
 
 PKGCONFIG_OVERRIDE+=	rtl433.pc.in
 
-pre-configure:
-	${RUN} ${MKDIR} ${WRKSRC}/build
+# \todo Remove or add a comment justifying.
+#pre-configure:
+#	${RUN} ${MKDIR} ${WRKSRC}/build
 
+# \todo Fix to install into examples/conf instead of removing, probably.
 pre-build:
 	${RM} ${WRKSRC}/conf/CMakeLists.txt
 
 post-install:
+	# \todo File a bug upstream about needing to install the manpage.
 	${INSTALL_MAN} ${WRKSRC}/man/man1/rtl_433.1 \
 	        ${DESTDIR}${PREFIX}/${PKGMANDIR}/man1
 	${RM} -rf ${DESTDIR}${PREFIX}/share/man
 	cd ${WRKSRC}/examples && ${PAX} -wr . ${DESTDIR}${PREFIX}/share/examples/rtl_433/
 	cd ${WRKSRC}/conf && ${PAX} -wr . ${DESTDIR}${PREFIX}/share/examples/rtl_433/conf/
 	cd ${WRKSRC}/docs && ${PAX} -wr . ${DESTDIR}${PREFIX}/share/doc/rtl_433/
+	# \todo remove in source before copying, to be cleaner
 	${RM} ${DESTDIR}${PREFIX}/share/doc/rtl_433/.gitignore
 
 .include "options.mk"