OpenSTA: swig3 buildlink, bison tool and TODOs added as per comments

[mayuresh <mayuresh%acm.org@localhost>]

Module Name:	pkgsrc-wip
Committed By:	mayuresh <mayuresh%acm.org@localhost>
Pushed By:	mayuresh
Date:		Fri Sep 13 09:04:52 2024 +0530
Changeset:	e820a429106d59b649d31a6dc4a285ac7a7a12ee

Modified Files:
	OpenSTA/Makefile
	OpenSTA/distinfo
Added Files:
	OpenSTA/TODO

Log Message:
OpenSTA: swig3 buildlink, bison tool and TODOs added as per comments

To see a diff of this commit:
https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=commitdiff;h=e820a429106d59b649d31a6dc4a285ac7a7a12ee

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

diffstat:
 OpenSTA/Makefile | 3 ++-
 OpenSTA/TODO     | 8 ++++++++
 OpenSTA/distinfo | 1 -
 3 files changed, 10 insertions(+), 2 deletions(-)

diffs:
diff --git a/OpenSTA/Makefile b/OpenSTA/Makefile
index 4dbd530839..4bbe7f8d8f 100644
--- a/OpenSTA/Makefile
+++ b/OpenSTA/Makefile
@@ -17,7 +17,7 @@ FORCE_CXX_STD=	c++20
 
 USE_LANGUAGES=	c++
 
-USE_TOOLS+= chmod cp
+USE_TOOLS+= chmod cp bison
 
 INSTALLATION_DIRS+=	etc
 
@@ -25,6 +25,7 @@ post-install:
 	${CP} -r ${WRKSRC}/etc/ ${DESTDIR}${PREFIX}
 	${CHMOD} +x ${DESTDIR}${PREFIX}/etc/TclEncode.tcl
 
+.include "../../devel/swig3/buildlink3.mk"
 .include "../../wip/cudd/buildlink3.mk"
 .include "../../lang/tcl/buildlink3.mk"
 .include "../../devel/cmake/build.mk"
diff --git a/OpenSTA/TODO b/OpenSTA/TODO
new file mode 100644
index 0000000000..3ac9ddcf15
--- /dev/null
+++ b/OpenSTA/TODO
@@ -0,0 +1,8 @@
+Following comments from Thomas need to be acted on:
+
+This is not according to pkgsrc standards:
+- use ${INSTALL_SCRIPT} instead of the cp and chmod
+- executable scripts should not be in etc but in bin or sbin or libexec
+- if it really is intended as a modifyable and executable script, it
+  should be installed in ${PREFIX}/share/examples/OpenSTA/ and copied
+  into ${PKGSYSCONFDIR} with the CONF_FILES mechanics.
diff --git a/OpenSTA/distinfo b/OpenSTA/distinfo
index c95a40766e..828584c076 100644
--- a/OpenSTA/distinfo
+++ b/OpenSTA/distinfo
@@ -3,4 +3,3 @@ $NetBSD$
 BLAKE2s (OpenSTA-2.5.0-2dcf169d9fe8a03aac659f9a214dd6dad6cefecf.tar.gz) = 09d22dd938de4086ec8a16d555979304a5732f51f5ee6dc4d18c89108f599fd1
 SHA512 (OpenSTA-2.5.0-2dcf169d9fe8a03aac659f9a214dd6dad6cefecf.tar.gz) = de1bf7ec6a561698ccbb078bc24f222209cfcdcda2dde82b8c048b48eea9290635dfbec35de897ec3ea25ba4f45c202ed9f60b8a0810621d34c06bb35e2a31c0
 Size (OpenSTA-2.5.0-2dcf169d9fe8a03aac659f9a214dd6dad6cefecf.tar.gz) = 7510689 bytes
-SHA1 (patch-CMakeLists.txt) = 03d106e4005ebc8775e954a7a6e2bfeaae250908