tcl-expect: Merge comment changes from lang/tcl-expect

[Greg Troxel <gdt%lexort.com@localhost>]

Module Name:	pkgsrc-wip
Committed By:	Greg Troxel <gdt%lexort.com@localhost>
Pushed By:	gdt
Date:		Tue Jun 14 07:02:09 2022 -0400
Changeset:	fac33e1f690736862d3c56c1346aa9df741a40c3

Modified Files:
	tcl-expect/Makefile.common
	tcl-expect/distinfo
	tcl-expect/patches/patch-Makefile.in
	tcl-expect/patches/patch-configure

Log Message:
tcl-expect: Merge comment changes from lang/tcl-expect

To see a diff of this commit:
https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=commitdiff;h=fac33e1f690736862d3c56c1346aa9df741a40c3

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

diffstat:
 tcl-expect/Makefile.common           |  5 ++++-
 tcl-expect/distinfo                  |  4 ++--
 tcl-expect/patches/patch-Makefile.in | 16 +++++++++++++++-
 tcl-expect/patches/patch-configure   | 19 ++++++++++++++++---
 4 files changed, 37 insertions(+), 7 deletions(-)

diffs:
diff --git a/tcl-expect/Makefile.common b/tcl-expect/Makefile.common
index db0f63588e..c7ab229bdf 100644
--- a/tcl-expect/Makefile.common
+++ b/tcl-expect/Makefile.common
@@ -1,4 +1,7 @@
-# $NetBSD: Makefile.common,v 1.12 2020/03/20 11:57:56 nia Exp $
+# $NetBSD: Makefile.common,v 1.14 2022/06/14 10:56:15 gdt Exp $
+
+# used by lang/tcl-expect/Makefile
+# \todo Explain why there is only one user, or fold into Makefile.
 
 DISTNAME=	expect${EXPECT_FNAME}
 MASTER_SITES=	${MASTER_SITE_SOURCEFORGE:=expect/}
diff --git a/tcl-expect/distinfo b/tcl-expect/distinfo
index bd3d3348cd..6d21dc9f07 100644
--- a/tcl-expect/distinfo
+++ b/tcl-expect/distinfo
@@ -3,7 +3,7 @@ $NetBSD: distinfo,v 1.22 2021/10/26 10:51:57 nia Exp $
 BLAKE2s (expect5.45.4.tar.gz) = 41310882c3658679f60911aca1a3cf9c353784f164410abf919ce7adefdc73e0
 SHA512 (expect5.45.4.tar.gz) = a8dc25e8175f67e029e15cbcfca1705165c1c4cb2dd37eaaaebffb61e3ba132d9519cd73ca5add4c3358a2b0b7a91e878279e8d0b72143ff2c287fce07e4659a
 Size (expect5.45.4.tar.gz) = 632363 bytes
-SHA1 (patch-Makefile.in) = 16ef8b14ae05b432b92b48d5fe0803d3024914d4
-SHA1 (patch-configure) = 095a64052903d7af168786ebba728a39302978ec
+SHA1 (patch-Makefile.in) = 7e6841ed49bd6242442a491b8228afbd93f8a6bb
+SHA1 (patch-configure) = 8478bbe10fc35718cd9a4b76757f8500c38b0ffe
 SHA1 (patch-retoglob.c) = 4406f9e5d7622f393e35e7a1f70a700a98d6e981
 SHA1 (patch-tclconfig_tcl.m4) = 45d1f405ca1b506c0a0fe60492b13ada111fa813
diff --git a/tcl-expect/patches/patch-Makefile.in b/tcl-expect/patches/patch-Makefile.in
index b1e316b4ab..10e8cd5ccc 100644
--- a/tcl-expect/patches/patch-Makefile.in
+++ b/tcl-expect/patches/patch-Makefile.in
@@ -1,6 +1,20 @@
 $NetBSD: patch-Makefile.in,v 1.4 2018/08/27 07:12:08 wiz Exp $
 
-New Makefile.in patch, no libtool taken from Original pkgsrc Makefil.in patches
+(This patch was created in 2012 and not adequately commented.  The
+comment included "no libtool", but there is no hint of libtool
+upstream and this patch does not remove it.)
+
+Define SHLIB_VERSION, mysteriously.
+
+Add a variable for a static library version, build and install it.
+
+Use standard rather than namespaced directories.
+
+Include LDFLAGS when linking (for RELRO).
+
+Version the shlib and the expect binary.
+
+\todo Push changes upstream, or explain why that's not appropriate.
 
 --- Makefile.in.orig	2018-02-02 12:15:52.000000000 -0700
 +++ Makefile.in	2022-06-09 06:35:29.261652426 -0600
diff --git a/tcl-expect/patches/patch-configure b/tcl-expect/patches/patch-configure
index 34bf156c8c..6cfef13164 100644
--- a/tcl-expect/patches/patch-configure
+++ b/tcl-expect/patches/patch-configure
@@ -1,9 +1,22 @@
 $NetBSD$
 
-#       configure patches to
-#       add support for svr5 and OpenServer 5 
+(This patch was created in 2012 and not adequately commented.  The
+comment included "no libtool", but there is no hint of libtool
+upstream and this patch does not remove it.)
 
-# emailed Upstream September 2019
+Add support for MirBSD as OpenBSD and DragonFly as FreeBSD.
+
+Upstream has support to use the version with or without dots as the
+shlib suffix.  This patch forces that to be the "NODOTS" flavor
+always, perhaps for PLIST consistency.
+
+\todo Expain why PVNODOTS isn't the PACKAGE_VERSION_NO_DOTS that
+upstream configure already computes.
+
+\todo Push changes upstream, or explain why that's not appropriate.
+
+Add support for SVR5 and OpenServer 5.  Sent upstream by email
+September 2019.
 
 --- configure.orig      2018-02-04 03:43:58.000000000 +0000
 +++ configure	2022-06-08 07:03:02.940051201 -0600