starfighter: update to starfighter-2.4

[Yorick Hardy <yorickhardy%gmail.com@localhost>]

Module Name:	pkgsrc-wip
Committed By:	Yorick Hardy <yorickhardy%gmail.com@localhost>
Pushed By:	yhardy
Date:		Sun Dec 27 20:18:26 2020 +0200
Changeset:	b72d121570ece42ed7ac3a30fea39ed0b1d765e2

Modified Files:
	starfighter/Makefile
	starfighter/PLIST
	starfighter/distinfo
Removed Files:
	starfighter/patches/patch-sound_Makefile.am

Log Message:
starfighter: update to starfighter-2.4

Release announcement:

I was going to say that this was another small bugfix, but it ended up being a
bit bigger than we expected, so we're bumping the version number of this up to
2.4. This came about from us fixing a massive bug that caused music to not be
installed properly (oops!), but then snowballed as we found more and more
improvements we wanted to make, mostly to the simulation of Project:
Starfighter version 1.1 via Classic difficulty. In fact it's so close to
version 1.1 now that we were able to outline all the noteworthy differences in
a dedicated page on the website, Old Bugs and Behaviors.

The notable changes include:

  * Added a Dutch translation contributed by Heimen Stoffels.
  * Made it so that the player starts at the same part of the screen in Classic
    difficulty as in version 1.1 (which is in the top-left quadrant rather than
    in the center).
  * Made it so that critical shield (that is, when you have only 1 shield left)
    causes more smoke particles to be generated.
  * Fixed a bug where Kline could continue circling while running away, causing
    him to flee diagonally at a rather slow speed (and also allowing you to
    kill him pretty easily).
  * Fixed a bug which caused music to not get installed properly (it was being
    installed in the sound directory instead of the music directory).
  * Made the Venus mission start in the same way as version 1.1 in Classic
    difficulty (albeit with a shorter delay, since the dialog is shorter than
    it was in version 1.1).
  * Made it so that the game doesn't go unresponsive to the OS when dying or
    after winning the Venus mission (meaning you don't have to wait for the
    game to proceed to the Game Over / Credits screen before you can quit the
    game normally, and also preventing weird bugs if you resize the window
    during that time).
  * Made it so that resizing the window in the credits screen repositions the
    credits text to the new center.
  * Simulated the smaller Kline health bars of version 1.1 in Classic
    difficulty. While Kline's health bar is still the larger size, its display
    is broken up into sections so that it now perfectly simulates version 1.1's
    Kline health bar behavior (a previous release already caused the portions
    of the health bar to be reduced in "steps", so they already behaved as if
    they were multiple health bars in Classic difficulty).
  * Made it possible to switch to concentrate mode even with the Super Charge
    in Classic difficulty, as was the case in the original.
  * Caused star position to be recalculated when you resize the window. This
    prevents weird gaps in the starfield when you make the window bigger in the
    middle of a mission, for instance.
  * Added an option to compile a binary that will attempt to use the original
    music. We won't be distributing that music because that is a violation of
    copyright, but for those who have the music and want to mod it into the
    game (no pun intended), it is now possible to do this without changing the
    source code. Simply pass SF_OLD_MUSIC=1 as an option to the configure
    script and it will attempt to load the original music file names and use
    them exactly as version 1.1 did.
  * Corrected the damage of micro rockets and triple-spread plasma bullets for
    Classic difficulty. These were both doubled at some point for balancing, so
    Classic difficulty now lowers the damage they inflict to their original
    values.

To see a diff of this commit:
https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=commitdiff;h=b72d121570ece42ed7ac3a30fea39ed0b1d765e2

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

diffstat:
 starfighter/Makefile                        |  4 ++--
 starfighter/PLIST                           |  2 ++
 starfighter/distinfo                        |  9 ++++-----
 starfighter/patches/patch-sound_Makefile.am | 15 ---------------
 4 files changed, 8 insertions(+), 22 deletions(-)

diffs:
diff --git a/starfighter/Makefile b/starfighter/Makefile
index c244fb9c44..c17e0309b3 100644
--- a/starfighter/Makefile
+++ b/starfighter/Makefile
@@ -1,9 +1,9 @@
 # $NetBSD$
 
-DISTNAME=	starfighter-2.3.3
+DISTNAME=	starfighter-2.4
 CATEGORIES=	games
 MASTER_SITES=	${MASTER_SITE_GITHUB:=pr-starfighter/}
-GITHUB_TAG=	v2.3.3
+GITHUB_TAG=	v2.4
 
 MAINTAINER=	pkgsrc-users%NetBSD.org@localhost
 HOMEPAGE=	https://pr-starfighter.github.io/
diff --git a/starfighter/PLIST b/starfighter/PLIST
index 4f2bc7a18b..a966c59e06 100644
--- a/starfighter/PLIST
+++ b/starfighter/PLIST
@@ -204,6 +204,8 @@ share/starfighter/locale/en/LC_MESSAGES/pr-starfighter.mo
 share/starfighter/locale/genpot.sh
 share/starfighter/locale/ja.po
 share/starfighter/locale/ja/LC_MESSAGES/pr-starfighter.mo
+share/starfighter/locale/nl.po
+share/starfighter/locale/nl/LC_MESSAGES/pr-starfighter.mo
 share/starfighter/locale/pr-starfighter.pot
 share/starfighter/music/RE.ogg
 share/starfighter/music/death.ogg
diff --git a/starfighter/distinfo b/starfighter/distinfo
index ca5d5c2b25..c641cd53dc 100644
--- a/starfighter/distinfo
+++ b/starfighter/distinfo
@@ -1,7 +1,6 @@
 $NetBSD$
 
-SHA1 (starfighter-2.3.3.tar.gz) = a7889260006167bc8145443b1d363f007d29bed7
-RMD160 (starfighter-2.3.3.tar.gz) = 078486ce113bd7d5d2dbcf7f1081b3b164edc74d
-SHA512 (starfighter-2.3.3.tar.gz) = 17cc74d7e17e7efcda366a882f4094c02132bad67730beb7e6644469b79226fe37001e0dafde964960d2b9e99e460de1b103f41017e4ceef2663468e75e1520e
-Size (starfighter-2.3.3.tar.gz) = 50190857 bytes
-SHA1 (patch-sound_Makefile.am) = fbbc22398f227402bee9ae3dffde8a6243e06937
+SHA1 (starfighter-2.4.tar.gz) = 312b17e3fab7b25813b0d5175ecd8e45cc104d5e
+RMD160 (starfighter-2.4.tar.gz) = 672f3e53f797a29b3b7b4b06f1d8dcc779069376
+SHA512 (starfighter-2.4.tar.gz) = 107b87d9aacd6c21b2f257a24bf18113663419c33200d6697fd3793436f68623108049ec22718021551c83b918a19c79d26ac30c4996276c416f13bc76384f42
+Size (starfighter-2.4.tar.gz) = 50221089 bytes
diff --git a/starfighter/patches/patch-sound_Makefile.am b/starfighter/patches/patch-sound_Makefile.am
deleted file mode 100644
index 5ceb421b1d..0000000000
--- a/starfighter/patches/patch-sound_Makefile.am
+++ /dev/null
@@ -1,15 +0,0 @@
-$NetBSD$
-
-Install sound files where it is expected.
-
---- sound/Makefile.am.orig	2020-09-20 16:14:06.000000000 +0000
-+++ sound/Makefile.am
-@@ -3,7 +3,7 @@
- # http://creativecommons.org/publicdomain/zero/1.0/ for more
- # information. This file is offered as-is, without any warranty.
- 
--sounddir = $(pkgdatadir)/music
-+sounddir = $(pkgdatadir)/sound
- 
- nobase_dist_sound_DATA = \
-     beamLaser.ogg \