cool-retro-term: Clean up all the pkglint warnings.

[Paul Ripke <stix%stix.id.au@localhost>]

Module Name:	pkgsrc-wip
Committed By:	Paul Ripke <stix%stix.id.au@localhost>
Pushed By:	stix
Date:		Wed Jul 22 12:22:23 2020 +1000
Changeset:	651bf6d0f17d51a6bc426ffc340bf5e25bbc88a9

Modified Files:
	cool-retro-term-git/Makefile
	cool-retro-term-git/distinfo
	cool-retro-term-git/patches/patch-qmltermwidget_lib_kpty_cpp

Log Message:
cool-retro-term: Clean up all the pkglint warnings.

To see a diff of this commit:
https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=commitdiff;h=651bf6d0f17d51a6bc426ffc340bf5e25bbc88a9

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

diffstat:
 cool-retro-term-git/Makefile                       | 32 ++++++++++++----------
 cool-retro-term-git/distinfo                       |  2 +-
 .../patches/patch-qmltermwidget_lib_kpty_cpp       |  3 ++
 3 files changed, 21 insertions(+), 16 deletions(-)

diffs:
diff --git a/cool-retro-term-git/Makefile b/cool-retro-term-git/Makefile
index 5a8fd93c1b..b57e3f9a7c 100644
--- a/cool-retro-term-git/Makefile
+++ b/cool-retro-term-git/Makefile
@@ -9,24 +9,24 @@ COMMENT=		Terminal emulator which mimics old cathode display artifacts
 LICENSE=		gnu-gpl-v3
 
 # For non-pkgsrc/wip:
-#MASTER_SITES=		${MASTER_SITE_GITHUB:=Swordfish90/}
-#TERM_TAG=		1.1.1
-#QMLTERMWIDGET_TAG=	0.2.0
-#DISTFILES+=		${TERM_TAG}.tar.gz
-#DISTFILES+=		${QMLTERMWIDGET_TAG}.tar.gz
-#DIST_SUBDIR=		cool-retro-term
-#SITES.${TERM_TAG}.tar.gz= \
-#	${MASTER_SITE_GITHUB:=Swordfish90/cool-retro-term/archive/}
-#SITES.${QMLTERMWIDGET_TAG}.tar.gz= \
-#	${MASTER_SITE_GITHUB:=Swordfish90/qmltermwidget/archive/}
-#WRKSRC=			${WRKDIR}/cool-retro-term-${TERM_TAG}
+# MASTER_SITES=		${MASTER_SITE_GITHUB:=Swordfish90/}
+# TERM_TAG=		1.1.1
+# QMLTERMWIDGET_TAG=	0.2.0
+# DISTFILES+=		${TERM_TAG}.tar.gz
+# DISTFILES+=		${QMLTERMWIDGET_TAG}.tar.gz
+# DIST_SUBDIR=		cool-retro-term
+# SITES.${TERM_TAG}.tar.gz= \
+#			${MASTER_SITE_GITHUB:=Swordfish90/cool-retro-term/archive/}
+# SITES.${QMLTERMWIDGET_TAG}.tar.gz= \
+#			${MASTER_SITE_GITHUB:=Swordfish90/qmltermwidget/archive/}
+# WRKSRC=		${WRKDIR}/cool-retro-term-${TERM_TAG}
 
 # For pkgsrc/wip:
-PKGREVISION=
-GIT_REPOSITORIES=	cool-retro-term
+PKGREVISION=			1
+GIT_REPOSITORIES=		cool-retro-term
 GIT_REPO.cool-retro-term=	git://github.com/Swordfish90/cool-retro-term.git
 GIT_TAG.cool-retro-term=	1.1.1
-WRKSRC=			${WRKDIR}/cool-retro-term
+WRKSRC=				${WRKDIR}/cool-retro-term
 
 SUBST_CLASSES+=		usrpath
 SUBST_STAGE.usrpath=	pre-configure
@@ -36,12 +36,13 @@ SUBST_SED.usrpath=	-e "s|/usr/|/usr/pkg/|g"
 
 DEPENDS+=		qt5-qtgraphicaleffects-[0-9]*:../../x11/qt5-qtgraphicaleffects
 
+ICON_THEMES=		yes
 USE_LANGUAGES=		c c++
 USE_TOOLS+=		pax
 MAKE_FLAGS+=		INSTALL_ROOT=${DESTDIR} sysconfdir=${PREFIX}/share
 
 # For non-pkgsrc/wip:
-#post-extract:
+# post-extract:
 #	# Move git submodule into the correct location.
 #	${MV} ${WRKDIR}/qmltermwidget-${QMLTERMWIDGET_TAG}/* ${WRKSRC}/qmltermwidget/
 
@@ -51,5 +52,6 @@ do-configure:
 .include "../../x11/qt5-qtbase/buildlink3.mk"
 .include "../../x11/qt5-qtdeclarative/buildlink3.mk"
 .include "../../x11/qt5-qtquickcontrols/buildlink3.mk"
+.include "../../graphics/hicolor-icon-theme/buildlink3.mk"
 .include "../../wip/mk/git-package.mk"
 .include "../../mk/bsd.pkg.mk"
diff --git a/cool-retro-term-git/distinfo b/cool-retro-term-git/distinfo
index 9e8dc5d2a8..b45ba8fb09 100644
--- a/cool-retro-term-git/distinfo
+++ b/cool-retro-term-git/distinfo
@@ -8,4 +8,4 @@ SHA1 (cool-retro-term/1.1.1.tar.gz) = 581809e75c70b42c6bac3e65f89428e79b5ff3b1
 RMD160 (cool-retro-term/1.1.1.tar.gz) = 61d6b1bd96a1c498638e414acef22a238940ff17
 SHA512 (cool-retro-term/1.1.1.tar.gz) = 59da4b5d18ad64b917caebbc63ea9e3d562ed2a2dc9eae00f36cf434df44d17adca084b448f860f24a74ee6b59cd083d6a81e2217df1fb5e9f2731eaf1752148
 Size (cool-retro-term/1.1.1.tar.gz) = 1975853 bytes
-SHA1 (patch-qmltermwidget_lib_kpty_cpp) = 10e9e9df943c372a4082865558c2125dce5761ad
+SHA1 (patch-qmltermwidget_lib_kpty_cpp) = 8d7e71c0212441b7a61d701ce9f2eb7abc41625f
diff --git a/cool-retro-term-git/patches/patch-qmltermwidget_lib_kpty_cpp b/cool-retro-term-git/patches/patch-qmltermwidget_lib_kpty_cpp
index 8d02993f99..8578a5038e 100644
--- a/cool-retro-term-git/patches/patch-qmltermwidget_lib_kpty_cpp
+++ b/cool-retro-term-git/patches/patch-qmltermwidget_lib_kpty_cpp
@@ -1,5 +1,8 @@
 $NetBSD$
 
+Fix terminal handling for handling for NetBSD.
+TODO: fix upstream.
+
 --- qmltermwidget/lib/kpty.cpp.orig	2018-11-25 08:06:16.000000000 +1100
 +++ qmltermwidget/lib/kpty.cpp	2020-07-21 12:19:27.296908414 +1000
 @@ -27,11 +27,19 @@