pkgsrc-WIP-changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

jabberd14: Address TODO comments with Makefile comments



Module Name:	pkgsrc-wip
Committed By:	Greg Troxel <gdt%lexort.com@localhost>
Pushed By:	gdt
Date:		Tue Oct 29 08:53:26 2019 -0400
Changeset:	012141d05e3119f9ff44900f49f1c0f1526fe7a4

Modified Files:
	jabberd14/Makefile
	jabberd14/TODO

Log Message:
jabberd14: Address TODO comments with Makefile comments

Explain the relationship between what's packaged and upstream
releases, and how that bears on importing to pkgsrc proper.  Based on
offlist discussion with triaxx@.

(This is a comment-only change.)

To see a diff of this commit:
https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=commitdiff;h=012141d05e3119f9ff44900f49f1c0f1526fe7a4

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

diffstat:
 jabberd14/Makefile | 16 +++++++++++++++-
 jabberd14/TODO     | 10 ----------
 2 files changed, 15 insertions(+), 11 deletions(-)

diffs:
diff --git a/jabberd14/Makefile b/jabberd14/Makefile
index 869f50c8dd..1c892b5781 100644
--- a/jabberd14/Makefile
+++ b/jabberd14/Makefile
@@ -1,6 +1,20 @@
 # $NetBSD: Makefile,v 1.44 2019/07/30 18:41:58 gdt Exp $
 
-DISTNAME=		jabberd-1.6.1.1
+# Upstream's latest release is 1.6.1.1, but this is old and has build
+# problems.  Upstream master is better, but upstream is choosing not
+# to make a release.  Therefore, package master in wip, and use a
+# version number that's higher than 1.6.1.1 and lower than any version
+# upstream might choose next.
+#
+# Because upstream is not publishing a release because of stability
+# concerns, this blocks moving this package to pkgsrc proper, as we do
+# generally not package non-releases against the wishes of upstreams.
+#
+# When imported, this will be jabberd14, to avoid confusion with
+# jabberd2, and to follow the pattern of all names having versions, if
+# there is more than one.
+# 
+DISTNAME=		jabberd-1.6.1.1.80
 CATEGORIES=		chat
 MASTER_SITES=		${MASTER_SITE_GITHUB:=mawis/}
 
diff --git a/jabberd14/TODO b/jabberd14/TODO
index 333e874bc3..992a36d882 100644
--- a/jabberd14/TODO
+++ b/jabberd14/TODO
@@ -1,11 +1 @@
 * handle option for PostgreSQL or MySQL
-
-# \todo This is jabberd14, which makes sense given jabberd2 in pkgsrc
-# proper, and longstanding confusion where people who intend to use
-# jabberd2 end up with 14.   If so, 
-
-# \todo Explain why, if the version is 1.6.1.1 this doesn't use the
-# 1.6.1.1 github release tag.  In particular, it looks like the tag is
-# on master, isn't actually the release, and has structural changes
-# relative to the release.  (Perhaps this is a clue that upstream is
-# overdue for a release :-).


Home | Main Index | Thread Index | Old Index