Re: (math/cgal) Trying to silence pkglint, Two left

[Leonardo Taccari <leot%NetBSD.org@localhost>]

Hello Makoto,
some possible adjustments/comments directly inline (all mostly
cosmetic/minor except the PKGMANDIR handling that IMHO it would be
better to be properly addressed before updating math/cgal).

Makoto Fujiwara (CF-SX3) writes:
> [...]
> @@ -1,9 +1,12 @@
>  # $NetBSD: Makefile,v 1.34 2017/08/24 20:03:00 adam Exp $
>  
> -DISTNAME=	CGAL-4.14
> -PKGNAME=	cgal-4.14
> -CATEGORIES=	wip
> -MASTER_SITES=	https://github.com/CGAL/cgal/releases/download/releases%2FCGAL-4.14/
> +VERSION=	4.14
> +DISTNAME=	CGAL-${VERSION}
> +PKGNAME=	${DISTNAME:tl}
> +CATEGORIES=	math
> +MASTER_SITES=	${MASTER_SITE_GITHUB:=CGAL/}
> +GITHUB_RELEASE=	releases/CGAL-${VERSION}
> +
>  EXTRACT_SUFX=	.tar.xz
>  

That's only cosmetic but VERSION can be removed and DISTNAME changed to:

 DISTNAME=        CGAL-4.14

...and GITHUB_RELEASE to:

 GITHUB_RELEASE=  releases/${DISTNAME} 

>  MAINTAINER=	reinoud%NetBSD.org@localhost
> @@ -13,6 +16,9 @@ LICENSE=	gnu-lgpl-v3
>  
>  USE_CMAKE=	yes
>  USE_LANGUAGES=	c c++03
> +# CMAKE_ARGS+=	-DCMAKE_INSTALL_MANDIR:PATH=${PKGMANDIR}  # default, but not effective now
> +# CMAKE_ARGS+=	-DCMAKE_INSTALL_MANDIR:STRING=${PKGMANDIR}
> +# CMAKE_ARGS+=	-DCMAKE_INSTALL_MANDIR=${PKGMANDIR}		# neither one work
>  

From a quick skim of the cmake files it seems that CGAL_INSTALL_MAN_DIR
is honored instead.  Have you tried to set it to
${PREFIX}/${PKGMANDIR}/man1 via `CMAKE_ARGS+= -DCGAL_INSTALL_MAN_DIR=...'?

>  REPLACE_BASH+=	scripts/cgal_create_CMakeLists
>  REPLACE_BASH+=	scripts/cgal_create_cmake_script

REPLACE_BASH is used but `bash' is not required as a tool, is this
intended?


Thank you!