vlc-git: Initial work towards sanitization of shared libs

[Kamil Rytarowski <n54%gmx.com@localhost>]

Module Name:	pkgsrc-wip
Committed By:	Kamil Rytarowski <n54%gmx.com@localhost>
Pushed By:	kamil
Date:		Wed Mar 14 06:30:54 2018 +0100
Changeset:	7b35af37e083a045dabf97bd15d0cd883c20ec94

Modified Files:
	vlc-git/Makefile
	vlc-git/distinfo
Added Files:
	vlc-git/patches/patch-compat_Makefile.am

Log Message:
vlc-git: Initial work towards sanitization of shared libs

We cannot build code with -static and expect it to work with a shared
library, in a portable way. We require to append -fPIC at least for
NetBSD.

To see a diff of this commit:
https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=commitdiff;h=7b35af37e083a045dabf97bd15d0cd883c20ec94

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

diffstat:
 vlc-git/Makefile                         |  3 ---
 vlc-git/distinfo                         |  1 +
 vlc-git/patches/patch-compat_Makefile.am | 13 +++++++++++++
 3 files changed, 14 insertions(+), 3 deletions(-)

diffs:
diff --git a/vlc-git/Makefile b/vlc-git/Makefile
index 984c82b676..5ad6f9d776 100644
--- a/vlc-git/Makefile
+++ b/vlc-git/Makefile
@@ -59,9 +59,6 @@ CONFIGURE_ARGS+=	--disable-vnc
 CONFIGURE_ARGS+=	--disable-vsxu
 CONFIGURE_ARGS+=	--disable-zvbi
 
-CFLAGS+=		-fPIC
-CXXFLAGS+=		-fPIC
-
 # which platforms support OSSv4?
 .if ${MACHINE_PLATFORM:MNetBSD-[789]*-*}
 PLIST.oss=		yes
diff --git a/vlc-git/distinfo b/vlc-git/distinfo
index 9f745ef1a4..fca1119adc 100644
--- a/vlc-git/distinfo
+++ b/vlc-git/distinfo
@@ -4,3 +4,4 @@ SHA1 (vlc-3.0.0.tar.xz) = 50610841b060321242793cf6ad3d58759dc5973b
 RMD160 (vlc-3.0.0.tar.xz) = c0ad23fdf03ae5c9524ed05c7bc0d63745587287
 SHA512 (vlc-3.0.0.tar.xz) = 9bdc64e16ddd2e8d2693179f2fcac8462d7defff186262a049ba325ef00882fbd75a9d323b506ba06876a8168fd5e90319837c8dcd136b206161e67748c2a9f7
 Size (vlc-3.0.0.tar.xz) = 25191148 bytes
+SHA1 (patch-compat_Makefile.am) = fdda7982210665c6b216f6a90dd49e08beba405a
diff --git a/vlc-git/patches/patch-compat_Makefile.am b/vlc-git/patches/patch-compat_Makefile.am
new file mode 100644
index 0000000000..64e6e7c22d
--- /dev/null
+++ b/vlc-git/patches/patch-compat_Makefile.am
@@ -0,0 +1,13 @@
+$NetBSD$
+
+--- compat/Makefile.am.orig	2018-03-14 05:22:09.618611871 +0000
++++ compat/Makefile.am
+@@ -1,7 +1,7 @@
+ pkglib_LTLIBRARIES = libcompat.la
+ libcompat_la_SOURCES = dummy.c
+ libcompat_la_LIBADD = $(LTLIBOBJS) $(LIBRT) $(LIBM)
+-libcompat_la_LDFLAGS = -no-undefined -static
++libcompat_la_LDFLAGS = -no-undefined
+ 
+ BUILT_SOURCES = dummy.c
+ CLEANFILES = dummy.c