pkgsrc-WIP-changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

rtv: Delete TODO, now NetBSD curses(3) correctly works as well



Module Name:	pkgsrc-wip
Committed By:	Leonardo Taccari <leot%NetBSD.org@localhost>
Pushed By:	leot
Date:		Tue Dec 5 22:13:45 2017 +0100
Changeset:	91222312ec67b3c0b9c10af6cca7e9e748c16ee4

Removed Files:
	rtv/TODO

Log Message:
rtv: Delete TODO, now NetBSD curses(3) correctly works as well

JFTR, a simple test case of the curses(3) issue, always in Python was:

 import curses

 stdscr = curses.initscr()
 subwin = stdscr.derwin(0, 0, 0, 0)
 subsubwin = subwin.derwin(0, 0, 0, 0)

(Nested subwindows from r1.37 to r1.50 of src/lib/libcurses/newwin.c weren't
allowed.)

Since revision r1.51 of src/lib/libcurses/newwin.c subwindow can be nested again
and NetBSD curses(3) works.

Thanks a lot to <roy> for fixing that!

To see a diff of this commit:
https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=commitdiff;h=91222312ec67b3c0b9c10af6cca7e9e748c16ee4

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

diffstat:
 rtv/TODO | 31 -------------------------------
 1 file changed, 31 deletions(-)

diffs:
diff --git a/rtv/TODO b/rtv/TODO
deleted file mode 100644
index 73c22cc7e2..0000000000
--- a/rtv/TODO
+++ /dev/null
@@ -1,31 +0,0 @@
-When built against devel/py-curses CURSES_TYPE=curses on NetBSD (tested with
-8.99.1), at run-time it fails with:
-
- % rtv
- Traceback (most recent call last):
-   File "/usr/pkg/bin/rtv", line 11, in <module>
-     load_entry_point('rtv==1.17.1', 'console_scripts', 'rtv')()
-   File "/usr/pkg/lib/python2.7/site-packages/pkg_resources/__init__.py", line 561, in load_entry_point
-     return get_distribution(dist).load_entry_point(group, name)
-   File "/usr/pkg/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2649, in load_entry_point
-     return ep.load()
-   File "/usr/pkg/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2303, in load
-     return self.resolve()
-   File "/usr/pkg/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2309, in resolve
-     module = __import__(self.module_name, fromlist=['__name__'], level=0)
-   File "/usr/pkg/lib/python2.7/site-packages/rtv/__main__.py", line 205, in <module>
-     sys.exit(main())
-   File "/usr/pkg/lib/python2.7/site-packages/rtv/__main__.py", line 188, in main
-     page.loop()
-   File "/usr/pkg/lib/python2.7/site-packages/rtv/page.py", line 81, in loop
-     self.draw()
-   File "/usr/pkg/lib/python2.7/site-packages/rtv/page.py", line 390, in draw
-     self._draw_content()
-   File "/usr/pkg/lib/python2.7/site-packages/rtv/page.py", line 508, in _draw_content
-     subwin_n_rows, subwin_n_cols, start, data['h_offset'])
- _curses.error: curses function returned NULL
- Exit 1
-
-Investigate why it fails in that way (only CURSES_TYPE=curses is affected,
-rebuilding or having a py-curses built with CURSES_TYPE=ncurses doesn't expose
-this problem).


Home | Main Index | Thread Index | Old Index