freeswitch-core: Fix pkglint warnings | Fix PLIST with new added modules | Add TODO

[Angel M. Adames <angelmadames%gmail.com@localhost>]

Module Name:	pkgsrc-wip
Committed By:	Angel M. Adames <angelmadames%gmail.com@localhost>
Pushed By:	angelmadames
Date:		Thu May 25 11:50:39 2017 -0400
Changeset:	e57acd4e03745c6363385a1ff869cfc454e69867

Modified Files:
	freeswitch-core/Makefile
	freeswitch-core/PLIST
	freeswitch-core/distinfo
	freeswitch-core/patches/patch-configure
	freeswitch-core/patches/patch-libs_spandsp_configure
	freeswitch-core/patches/patch-libs_spandsp_unpack__gsm0610__data.sh
	freeswitch-core/patches/patch-libs_unimrcp_configure
	freeswitch-core/patches/patch-modules.conf
Added Files:
	freeswitch-core/TODO

Log Message:
freeswitch-core: Fix pkglint warnings | Fix PLIST with new added modules | Add TODO

To see a diff of this commit:
https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=commitdiff;h=e57acd4e03745c6363385a1ff869cfc454e69867

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

diffstat:
 freeswitch-core/Makefile                           |  6 +++--
 freeswitch-core/PLIST                              |  5 +++++
 freeswitch-core/TODO                               | 26 ++++++++++++++++++++++
 freeswitch-core/distinfo                           |  9 ++++----
 freeswitch-core/patches/patch-configure            |  2 ++
 .../patches/patch-libs_spandsp_configure           |  2 ++
 .../patch-libs_spandsp_unpack__gsm0610__data.sh    |  2 ++
 .../patches/patch-libs_unimrcp_configure           |  2 ++
 freeswitch-core/patches/patch-modules.conf         |  2 ++
 9 files changed, 50 insertions(+), 6 deletions(-)

diffs:
diff --git a/freeswitch-core/Makefile b/freeswitch-core/Makefile
index f9fff35a3d..b49326ad1f 100644
--- a/freeswitch-core/Makefile
+++ b/freeswitch-core/Makefile
@@ -19,8 +19,6 @@ USE_TOOLS+=     	automake autoconf gmake perl pkg-config
 
 BUILD_DEFS+=		VARBASE
 
-SYSCONFSUBDIR=		freeswitch
-
 CONFIGURE_ARGS+=	--prefix=${PREFIX}
 CONFIGURE_ARGS+=	--exec-prefix=${PREFIX}/bin
 CONFIGURE_ARGS+=	--bindir=${PREFIX}/bin
@@ -46,6 +44,8 @@ CONFIGURE_ARGS+=	--with-modinstdir=${PREFIX}/freeswitch/modules
 CONFIGURE_ARGS+=	--disable-libvpx
 CONFIGURE_ARGS+=	--enable-srtp
 CONFIGURE_ARGS+=	--enable-zrtp
+CONFIGURE_ARGS+=	--enable-core-pgsql-support
+CONFIGURE_ARGS+=	--enable-xmlrpc-c
 
 REPLACE_PERL+=	support-d/utils/filebug.pl
 REPLACE_PERL+=	support-d/utils/gl
@@ -173,6 +173,7 @@ post-install:
 	${LIBTOOL} --finish ${PREFIX}/lib
 
 .include "../../devel/pcre/buildlink3.mk"
+.include "../../mk/pgsql.buildlink3.mk"
 .include "../../devel/libmemcached/buildlink3.mk"
 .include "../../lang/lua52/buildlink3.mk"
 .include "../../multimedia/libvpx/buildlink3.mk"
@@ -184,4 +185,5 @@ post-install:
 .include "../../databases/sqlite3/buildlink3.mk"
 .include "../../devel/libltdl/buildlink3.mk"
 .include "../../mk/jpeg.buildlink3.mk"
+.include "../../devel/libuuid/buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"
diff --git a/freeswitch-core/PLIST b/freeswitch-core/PLIST
index 6bb1e715cd..dd22e8f60e 100644
--- a/freeswitch-core/PLIST
+++ b/freeswitch-core/PLIST
@@ -216,12 +216,16 @@ etc/freeswitch/vars.xml
 etc/freeswitch/voicemail.tpl
 etc/freeswitch/web-vm.tpl
 freeswitch/modules/mod_amr.la
+freeswitch/modules/mod_avmd.la
 freeswitch/modules/mod_b64.la
+freeswitch/modules/mod_callcenter.la
 freeswitch/modules/mod_cdr_csv.la
 freeswitch/modules/mod_cdr_sqlite.la
+freeswitch/modules/mod_cidlookup.la
 freeswitch/modules/mod_commands.la
 freeswitch/modules/mod_conference.la
 freeswitch/modules/mod_console.la
+freeswitch/modules/mod_curl.la
 freeswitch/modules/mod_db.la
 freeswitch/modules/mod_dialplan_asterisk.la
 freeswitch/modules/mod_dialplan_xml.la
@@ -241,6 +245,7 @@ freeswitch/modules/mod_local_stream.la
 freeswitch/modules/mod_logfile.la
 freeswitch/modules/mod_loopback.la
 freeswitch/modules/mod_lua.la
+freeswitch/modules/mod_memcache.la
 freeswitch/modules/mod_native_file.la
 freeswitch/modules/mod_opus.la
 freeswitch/modules/mod_png.la
diff --git a/freeswitch-core/TODO b/freeswitch-core/TODO
new file mode 100644
index 0000000000..2f96eca562
--- /dev/null
+++ b/freeswitch-core/TODO
@@ -0,0 +1,26 @@
+* There are some bundled libs that are currently imported to pkgsrc & pkgsrc-wip.
+  Nevertheless, these bundled libs, from what I could see, are modified by upstream.
+  I ran into many errors while integrating pkgsrc libs instead of the bundled ones.
+  Thus, further work needs to be done to make them work. 
+
+* There are many modules that are not enabled by default. If an user requires them,
+  they have to be manually enabled in ${WRKSRC}/modules.conf file. As for now, 
+  defaults are enabled + some required by wip/fusionpbx (GUI interface).
+
+* Once installed, FS is unable to identify the local_ip_v4 value.
+  Meaning sofia-sip moduel cannot bind to an interface. The temporary workaround is,
+  to manually set the local_ip_v4 value in conf_dir/vars.xml.
+  Example:  <X-PRE-PROCESS cmd="set" date="local_ip_v4=[yo.ur.i.p]"/>
+
+* The event_socket_module, which is the one fs_cli connects to,
+  by default has an IPv6 configuration, therefore it is unable to load
+  properly. You'll need to set to your local IP or 0.0.0.0 un the
+  event_socket.conf.xml file inside autoloads/configs directory.
+
+* If you are willing to use FusionPBX as GUI, you'll need to copy
+  the scripts from FusionPBX to FS. Also, you may need to copy
+  FusionPBX templates, depending on your configuration scheme.
+
+* Use of CONF_FILES framework to avoid pkglint errors. 
+
+* This package has only been tested on FreeBSD 11.  
diff --git a/freeswitch-core/distinfo b/freeswitch-core/distinfo
index 407738ecfb..2de04249a0 100644
--- a/freeswitch-core/distinfo
+++ b/freeswitch-core/distinfo
@@ -4,7 +4,8 @@ SHA1 (freeswitch-1.6.17.tar.xz) = feda8e9334410bee1e5ae4d959a0982cf18c5bee
 RMD160 (freeswitch-1.6.17.tar.xz) = d0ce212e924a77c7a9605f375bf2a61210195fc3
 SHA512 (freeswitch-1.6.17.tar.xz) = 09859c16fee07d6b7f8a54f7149bc56b49ef82d4fdf6df97df2611d117f3a6256f68bfaf19e4a307c9da0b7c80b942f02e5be4a85df3cc3f0f0a5f75ad731fa8
 Size (freeswitch-1.6.17.tar.xz) = 33626976 bytes
-SHA1 (patch-configure) = 9e75606d1f0edb7a29b2533af59e28adff5be03f
-SHA1 (patch-libs_spandsp_configure) = c5ca9b0ac06f598420712f42f73ed870b286e8dd
-SHA1 (patch-libs_spandsp_unpack__gsm0610__data.sh) = ade7a9c0e5a91eff5b947bca56d8100712b21642
-SHA1 (patch-libs_unimrcp_configure) = 4d6d9141bcdb2e629d5f9f421e724c2a7a2d64d3
+SHA1 (patch-configure) = 76661c5bd14857de5fcea046d58f2ec46c04d767
+SHA1 (patch-libs_spandsp_configure) = ace14e1f5ed3318c2f3a0ec7f47bbdf6308a2f34
+SHA1 (patch-libs_spandsp_unpack__gsm0610__data.sh) = facfda4025aeb36f9277b088dace41442417ec9c
+SHA1 (patch-libs_unimrcp_configure) = d4ce12c4bc47e89ac60675c9fc9d67dd546061ba
+SHA1 (patch-modules.conf) = 8c59f28a9f3247f996debf8d8547c9f8de50b7ed
diff --git a/freeswitch-core/patches/patch-configure b/freeswitch-core/patches/patch-configure
index 4eb0db971e..28d82df856 100644
--- a/freeswitch-core/patches/patch-configure
+++ b/freeswitch-core/patches/patch-configure
@@ -1,5 +1,7 @@
 $NetBSD$
 
+Fix portability issues.
+
 --- configure.orig	2017-04-30 00:54:20.670300000 +0000
 +++ configure
 @@ -36856,7 +36856,7 @@ if test "$with_ldap" = "yes"; then
diff --git a/freeswitch-core/patches/patch-libs_spandsp_configure b/freeswitch-core/patches/patch-libs_spandsp_configure
index 8dbdb2733a..bd29e883e9 100644
--- a/freeswitch-core/patches/patch-libs_spandsp_configure
+++ b/freeswitch-core/patches/patch-libs_spandsp_configure
@@ -1,5 +1,7 @@
 $NetBSD$
 
+Fix portability issues.
+
 --- libs/spandsp/configure.orig	2017-04-19 13:12:06.824318000 +0000
 +++ libs/spandsp/configure
 @@ -24108,7 +24108,7 @@ done
diff --git a/freeswitch-core/patches/patch-libs_spandsp_unpack__gsm0610__data.sh b/freeswitch-core/patches/patch-libs_spandsp_unpack__gsm0610__data.sh
index 27f8bf6f78..4d9527dc95 100644
--- a/freeswitch-core/patches/patch-libs_spandsp_unpack__gsm0610__data.sh
+++ b/freeswitch-core/patches/patch-libs_spandsp_unpack__gsm0610__data.sh
@@ -1,5 +1,7 @@
 $NetBSD$
 
+Fix portability issues.
+
 --- libs/spandsp/unpack_gsm0610_data.sh.orig	2017-04-19 13:14:01.304432000 +0000
 +++ libs/spandsp/unpack_gsm0610_data.sh
 @@ -53,7 +53,7 @@ else
diff --git a/freeswitch-core/patches/patch-libs_unimrcp_configure b/freeswitch-core/patches/patch-libs_unimrcp_configure
index b17dfcaa3b..03efc0d169 100644
--- a/freeswitch-core/patches/patch-libs_unimrcp_configure
+++ b/freeswitch-core/patches/patch-libs_unimrcp_configure
@@ -1,5 +1,7 @@
 $NetBSD$
 
+Fix portability issues.
+
 --- libs/unimrcp/configure.orig	2017-04-19 13:12:50.546788000 +0000
 +++ libs/unimrcp/configure
 @@ -18033,7 +18033,7 @@ fi
diff --git a/freeswitch-core/patches/patch-modules.conf b/freeswitch-core/patches/patch-modules.conf
index c48e3ec8c0..3a17a0f041 100644
--- a/freeswitch-core/patches/patch-modules.conf
+++ b/freeswitch-core/patches/patch-modules.conf
@@ -1,5 +1,7 @@
 $NetBSD$
 
+Fix portability issues.
+
 --- modules.conf.orig	2017-05-05 17:08:45.600465000 +0000
 +++ modules.conf
 @@ -1,14 +1,14 @@