lldb-netbsd: Update TODO for next milestone; disable (v)fork monitor

[Kamil Rytarowski <n54%gmx.com@localhost>]

Module Name:	pkgsrc-wip
Committed By:	Kamil Rytarowski <n54%gmx.com@localhost>
Pushed By:	kamil
Date:		Sun Jan 22 12:17:11 2017 +0100
Changeset:	b6f36a095d775699146c81a244fa682b44e31da1

Modified Files:
	lldb-netbsd/TODO
	lldb-netbsd/distinfo
	lldb-netbsd/patches/patch-source_Plugins_Process_NetBSD_NativeProcessNetBSD.cpp

Log Message:
lldb-netbsd: Update TODO for next milestone; disable (v)fork monitor

Add a note on debugging the GDB remote protocol.

Remove entries for the "current milestone" as it's finished now.
Change "short-term goals in the next milestone" to the current ones.
Add two new ptrace(2) entries to the roadmap.

Disable monitor for (v)fork-like events, support for them is not planned for
the LLDB porting goal as of today.

Sponsored by <The NetBSD Foundation>

To see a diff of this commit:
https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=commitdiff;h=b6f36a095d775699146c81a244fa682b44e31da1

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

diffstat:
 lldb-netbsd/TODO                                     | 20 ++++++++------------
 lldb-netbsd/distinfo                                 |  2 +-
 ...ce_Plugins_Process_NetBSD_NativeProcessNetBSD.cpp |  6 +++---
 3 files changed, 12 insertions(+), 16 deletions(-)

diffs:
diff --git a/lldb-netbsd/TODO b/lldb-netbsd/TODO
index 12d8d38..77f3c11 100644
--- a/lldb-netbsd/TODO
+++ b/lldb-netbsd/TODO
@@ -1,6 +1,11 @@
 Debugging to a file:
     log enable -STagnpstv -f /tmp/log.txt lldb all
 
+Debugging GDB remote protocol commands:
+    log enable gdb-remote packets
+
+    https://sourceware.org/gdb/onlinedocs/gdb/Remote-Protocol.html
+
 Debugging with gdb(1):
     Start the server:
         gdb --args lldb-server g *:1234 -- ./signal
@@ -20,24 +25,15 @@ Introduce objc++ setup with gcc(1) for "make test":
 llvm::call_once hack for src:
    curl https://github.com/jsonn/src/commit/78f4ee4c8349d68cf2279f2c7fc2196ae369e182.patch|gpatch -R -p1
 
-The current milestone is to detect in Monitor Callback the following events:
- - process termination - works, appropriate return status passed to LLDB
- - execve(2) - works, switch to new image not tested but all the code seems to be there
- - software breakpoint (TRAP_BRKPT) - works, stop on breakpoint and resume from breakpoint OK
- - single step - seems to work, but doesn't return to user for each step
- - fork - should be detected, but for now skipped
- - vfork-done - detected, but for now skipped
- - lwp creation/termination - works, stop on it and resume works, LWP list updated correctly
- - hardware breakpoint - currently not easily testable (skipped)
- - other signal passed to tracee - works, stop on it and resume works
-
-Short-term goals in next milestone:
+Short-term goals in current milestone:
  - fix conflict with system-wide py-six
  - add support for auxv read operation
  - switch resolution of pid -> path to executable from /proc to sysctl(7)
  - recognize Real-Time Signals (SIGRTMIN-SIGRTMAX)
  - upstream !NetBSDProcessPlugin code
  - switch std::call_once to llvm::call_once
+ + ptrace(2) interface to lock and unlock threads from execution
+ + switch the current PT_WATCHPOINT interface to PT_GETDBREGS and PT_SETDBREGS
 
 To be done later:
  - registers' accessors
diff --git a/lldb-netbsd/distinfo b/lldb-netbsd/distinfo
index e66c258..7bd9e02 100644
--- a/lldb-netbsd/distinfo
+++ b/lldb-netbsd/distinfo
@@ -28,7 +28,7 @@ SHA1 (patch-source_Plugins_Platform_NetBSD_PlatformNetBSD.cpp) = 129e853c1f93f06
 SHA1 (patch-source_Plugins_Platform_NetBSD_PlatformNetBSD.h) = 4327a21e79378b8f35adb07614adb41c37bbaf61
 SHA1 (patch-source_Plugins_Process_CMakeLists.txt) = c0168f81da56d9896eb414e6b8bb7262de04ac33
 SHA1 (patch-source_Plugins_Process_NetBSD_CMakeLists.txt) = df17afdf71c29d945c887e318718904793cd48ad
-SHA1 (patch-source_Plugins_Process_NetBSD_NativeProcessNetBSD.cpp) = f2ed22a7b37a07fc89160760cd8c03fdb5b154cb
+SHA1 (patch-source_Plugins_Process_NetBSD_NativeProcessNetBSD.cpp) = 46ca5bd672a87e9af6eef44989ead304b542f518
 SHA1 (patch-source_Plugins_Process_NetBSD_NativeProcessNetBSD.h) = bdd9fe37e47de8fa626c7eacf81e07d47a76787c
 SHA1 (patch-source_Plugins_Process_NetBSD_NativeThreadNetBSD.cpp) = a92c655c447cc0829fdb48786f474929f09e1a71
 SHA1 (patch-source_Plugins_Process_NetBSD_NativeThreadNetBSD.h) = d251c4f1b52089f96d435a99f45353aa3992924a
diff --git a/lldb-netbsd/patches/patch-source_Plugins_Process_NetBSD_NativeProcessNetBSD.cpp b/lldb-netbsd/patches/patch-source_Plugins_Process_NetBSD_NativeProcessNetBSD.cpp
index 039a385..26a804c 100644
--- a/lldb-netbsd/patches/patch-source_Plugins_Process_NetBSD_NativeProcessNetBSD.cpp
+++ b/lldb-netbsd/patches/patch-source_Plugins_Process_NetBSD_NativeProcessNetBSD.cpp
@@ -1,6 +1,6 @@
 $NetBSD$
 
---- source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp.orig	2017-01-20 20:30:48.330267591 +0000
+--- source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp.orig	2017-01-21 18:35:30.311662060 +0000
 +++ source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp
 @@ -0,0 +1,1387 @@
 +//===-- NativeProcessNetBSD.cpp -------------------------------- -*- C++ -*-===//
@@ -452,17 +452,17 @@ $NetBSD$
 +Error NativeProcessNetBSD::SetDefaultPtraceOpts(lldb::pid_t pid) {
 +  ptrace_event_t event = {};
 +
++#if notyet
 +  // Report forks
 +  event.pe_set_event |= PTRACE_FORK;
 +
 +  // Report vforks
 +  // TODO: Currently unsupported in NetBSD
-+#if notyet
 +  event.pe_set_event |= PTRACE_VFORK;
-+#endif
 +
 +  // Report finished vforks - the parent unblocked after execve(2) or exit(2) of the child
 +  event.pe_set_event |= PTRACE_VFORK_DONE;
++#endif
 +
 +  // Report LWP (thread) creation
 +  event.pe_set_event |= PTRACE_LWP_CREATE;