pkgsrc-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: possible dependency issue in virt-viewer



Irene Knapp <ireneista@irenes.space> writes:

> I noticed that virt-viewer built without spice support, despite it
> correctly installing spice-gtk as a dependency. This can be seen from
> the output of ./configure, which for me was consistently reporting an
> empty value for SPICE_GTK.

One could read the configure.ac content, and it's quite possible that
it's looking for introspection bindings.  The way software is divideed
into packages can differ across packaging systems, and upstreams
typically don't explain the needed dependencies well.  What you found
does not seem strange.

> I believe the below change fixes it, but I don't think this is the
> most elegant change - it doesn't seem as if it should be necessary and
> the actual breakage is likely in some intermediate dependency, between
> the two.

The pkgsrc way is that if package A uses the contents package B at build
or runtime, then A needs to express some kind of dependency.  The kind
of intermediate dependency error can happen too.

There is also glib2-introspection.  That contains the introspection
files for glib2, and it's separate becuase gobject-introspection needs
glib2 to build.  I'm not saying it's needed -- just that it exists and
when working on a different package I found that it was needed.

> Alas I'm insufficiently familiar with pkgsrc to figure out
> where it should be, so I just offer this in case anyone else knows how
> to do that part.
>
> I'm new enough to this that I don't know the best way to report what
> version I'm on; it's a recent CVS checkout.

You can read sysutils/virt-viewer/Makefile; that's much easier to read
and sort of understand than to write.  It says that virt-viewer's
version is 8.0.  And, PKGREVISION -- incremented for pkgsrc changes that
are not upstream changes -- is 52.  That's a clue that the package has
not had an upstream update applied to pkgsrc for a very long time.  It's
been 8.0 since February of 2020.

There is a newer version 11.0 but it's from 2021.

> Index: Makefile
> ===================================================================
> RCS file: /cvsroot/pkgsrc/sysutils/virt-viewer/Makefile,v
> retrieving revision 1.54
> diff -u -p -r1.54 Makefile
> --- Makefile 11 Nov 2026 11:55:49 -0000 1.54
> +++ Makefile 15 Nov 2026 06:14:34 -0000
> @@ -17,6 +17,7 @@ GNU_CONFIGURE= yes
> USE_PKGLOCALEDIR= yes
>
> .include "../../devel/glib2/buildlink3.mk"
> +.include "../../devel/gobject-introspection/buildlink3.mk"
> .include "../../graphics/hicolor-icon-theme/buildlink3.mk"
> .include "../../net/gtk-vnc/buildlink3.mk"
> .include "../../security/libgcrypt/buildlink3.mk"

This seems pretty likely to be a correct change.  I'm building it now
and may commit the change if I think it's right, after looking a bit.


Home | Main Index | Thread Index | Old Index