pkgsrc-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: "pkgtools/digest" not installed when building "benchmarks/hyperfine"



* On 2026-11-10 at 10:53 GMT, Thomas Klausner wrote:

On Tue, Nov 10, 2026 at 10:52:08AM +0100, Jonathan Perkin wrote:
* On 2026-11-10 at 10:47 GMT, Thomas Klausner wrote:

> On Tue, Nov 10, 2026 at 11:40:19AM +0100, Matti Andreas Kähäri wrote:
> > Yes, there is no "work" directory anywhere:
>
> You're right, I can reproduce this in an empty sandbox.
>
> It wants to check checksums before installing tool dependencies:
>
> # make
> ... checking checksums ...
> work -> /tmp/benchmarks/hyperfine/work
> ===> Installing dependencies for hyperfine-1.20.0
> => Tool dependency cwrappers>=20150314: NOT found
> => Verifying reinstall for ../../pkgtools/cwrappers
> work -> /tmp/pkgtools/cwrappers/work
> ===> Installing dependencies for cwrappers-20220403
> => Build dependency libnbcompat>=20221013: NOT found
> => Verifying reinstall for ../../pkgtools/libnbcompat
> work -> /tmp/pkgtools/libnbcompat/work
> ===> Installing dependencies for libnbcompat-20251029
> ===> Overriding tools for libnbcompat-20251029
> ===> Extracting for libnbcompat-20251029
> ===> Patching for libnbcompat-20251029
> ===> Creating toolchain wrappers for libnbcompat-20251029
>
> This fixes it:
>
> /usr/pkgsrc/lang/rust> cvs di
> Index: cargo.mk
> ===================================================================
> RCS file: /cvsroot/pkgsrc/lang/rust/cargo.mk,v
> retrieving revision 1.48
> diff -u -r1.48 cargo.mk
> --- cargo.mk	1 Oct 2026 06:53:07 -0000	1.48
> +++ cargo.mk	10 Nov 2026 10:46:06 -0000
> @@ -37,7 +37,7 @@
>
> .include "../../lang/rust/rust.mk"
>
> -USE_TOOLS+=		bsdtar digest
> +USE_TOOLS+=		bsdtar
> CARGO_VENDOR_DIR=	${WRKDIR}/vendor
> CARGO_WRKSRC?=		${WRKSRC}
>
>
> which was added in
>
> revision 1.39
> date: 2024-10-11 14:42:10 +0200;  author: jperkin;  state: Exp;  lines: +2 -2;  commitid: 2JKIMZxGm7r47ftF;
> lang/rust: Add digest to USE_TOOLS.
>
> This has relied on the fact that digest is usually already added to
> USE_TOOLS, but needs to be explicit as that may not always be the case.
>
> Jonathan, can you please take a look at this?

So how does the ${DIGEST} call in cargo-vendor-crates work after this
change?

I'm not saying that the change is correct (I suspect it isn't), I'm
just saying how I tracked down the commit that caused this.

Ah ok, I misunderstood. In that case I believe the correct fix is to change it to "digest:bootstrap" so that it is available at the correct time - can you both confirm this works?

--
Jonathan Perkin                    pkgsrc.smartos.org
Open Source Complete Cloud   www.tritondatacenter.com


Home | Main Index | Thread Index | Old Index