Re: python3.13 fails to build on macOS 26

[Greg Troxel <gdt%lexort.com@localhost>]

Adam <adam%netbsd.org@localhost> writes:

> Anyway, the problem remains with older macOS versions/older Xcode. I
> tried to auto-detect the proper expat, but it doesn't seems to really
> work:

If by "older" you include macOS 15, then we  need to fix that.
It's hard to say how far back really ought to work; it's no longer 10.13
that it was for a while of course, and it might be macOS 13.

> RCS file: /cvsroot/pkgsrc/textproc/expat/builtin.mk,v
> retrieving revision 1.27
> diff -u -r1.27 builtin.mk
> --- builtin.mk 31 Jan 2026 17:39:20 -0000 1.27
> +++ builtin.mk 18 Jun 2026 05:15:36 -0000
> @@ -3,7 +3,7 @@
>  BUILTIN_PKG:= expat
>    BUILTIN_FIND_HEADERS_VAR:= H_EXPAT
> -BUILTIN_FIND_HEADERS.H_EXPAT= expat.h
> +BUILTIN_FIND_HEADERS.H_EXPAT= expat.h expat_config.h
>    .include "../../mk/buildlink3/bsd.builtin.mk"

Did you commit that?

We need to decide what "require expat means", document that, and adjust
builtin.mk to only accept builtin if it is new enough.   I think it's ok
to err on the side of not accepting bulitin expat, or certainly better
than the other way around.

I don't know when expat_config.h appeared and how that relates to expat
version numbers, but if the expat-using world expects expat_config, it
makes sense to make it required for builtin.