I meant to send this to pkgsrc-users%netbsd.org@localhost as well.
I made some further changes for review in wip/dovecot24.
Dovecot dubiously defines a bunch of visibility #defines in its
src/src/lib.h and patching out the lot of them also made setting
_NETBSD_SOURCE unneeded, so I dropped it from Makefile.common.
I suspect that the remaining ones
# Enable platform specific extensions
CFLAGS.FreeBSD+= -D__BSD_VISIBLE -D__XSI_VISIBLE
CFLAGS.OpenBSD+= -D__BSD_VISIBLE -D__XSI_VISIBLE
CFLAGS.SunOS+= -D__EXTENSIONS__
are also unneeded now but I could not test that.
I reviewed the patches from dovecot 2.3 and several of them were applied
upstream. Also several added an include <sys/time.h>, but I suspect
those are no longer needed since it doesn't break the build if they are
absent.
I did include a private patch of mine, simply because I want it in my
local build (although the thing it wants to prevent didn't happen yet in
my quick local test). It prevents that mails change from N to O (in Mutt
terms) behind the user's back ("new and unread" to "old and unread").
Dovecot 2.3 had example config files split out in a dovecot/conf.d
directory but 2.4 doesn't. This is another annoying difference when you
want to convert your config. In the end I went with the output from
"doveconf -n" (show non-default settings) and stuffed the converted
version of that just in the main dovecot.conf file.
-Olaf.
--
___ Olaf 'Rhialto' Seibert <rhialto/at/falu.nl>
\X/ There is no AI. There is just someone else's work. --I. Rose
Attachment:
signature.asc
Description: PGP signature