Re: CVS commit: pkgsrc/x11/rxvt

[Thomas Klausner <wiz%netbsd.org@localhost>]

Please include mk/compiler.mk before the check and put it in the
middle of the Makefile, not at the bottom, instead.

An alternative we've been doing in a couple packages is to add the
missing 'int' to the configure script.

 Thomas


On Sat, Oct 11, 2025 at 09:53:52AM +0100, Martin Husemann wrote:
> Module Name:	pkgsrc
> Committed By:	martin
> Date:		Sat Oct 11 09:53:52 UTC 2025
> 
> Modified Files:
> 	pkgsrc/x11/rxvt: Makefile
> 
> Log Message:
> Hack to allow building with newer gcc
> 
> 
> To generate a diff of this commit:
> cvs rdiff -u -r1.66 -r1.67 pkgsrc/x11/rxvt/Makefile
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
> 

> Modified files:
> 
> Index: pkgsrc/x11/rxvt/Makefile
> diff -u pkgsrc/x11/rxvt/Makefile:1.66 pkgsrc/x11/rxvt/Makefile:1.67
> --- pkgsrc/x11/rxvt/Makefile:1.66	Wed Nov 24 06:55:41 2021
> +++ pkgsrc/x11/rxvt/Makefile	Sat Oct 11 09:53:52 2025
> @@ -1,4 +1,4 @@
> -# $NetBSD: Makefile,v 1.66 2021/11/24 06:55:41 pho Exp $
> +# $NetBSD: Makefile,v 1.67 2025/10/11 09:53:52 martin Exp $
>  
>  DISTNAME=		rxvt-2.7.10
>  PKGREVISION=		10
> @@ -66,3 +66,7 @@ post-install:
>  .include "../../x11/libXpm/buildlink3.mk"
>  .include "../../x11/libXt/buildlink3.mk"
>  .include "../../mk/bsd.pkg.mk"
> +
> +.if !empty(CC_VERSION:Mgcc-14.*) || !empty(CC_VERSION:Mgcc-15.*)
> +CFLAGS+=	-Wno-implicit-function-declaration -Wno-implicit-int
> +.endif
>