Re: Rebuilding firefore

[Rob Whitlock <rwhitlock22%gmail.com@localhost>]

> On Apr 4, 2025, at 7:07 AM, Thomas Klausner <wiz%gatalith.at@localhost> wrote:
> 
> On Fri, Apr 04, 2025 at 10:41:30AM -0400, Todd Gruhn wrote:
>> The error is  below. The meson prob showed up again.
>> How do I fix it?
>> Whack  /usr/pkg and rebuild all? HMMMMMM...
>> 
>> 
>> Run-time dependency xcomposite found: YES 0.4.6
>> Run-time dependency fontconfig found: YES 2.15.0
>> Run-time dependency atk-bridge-2.0 found: NO (tried pkgconfig)
>> 
>> meson.build:570:19: ERROR: Dependency "atk-bridge-2.0" not found,
>> tried pkgconfig
>> 
>> A full log can be found at
>> /usr/pkgsrc/x11/gtk3/work/gtk+-3.24.43/output/meson-logs/meson-log.txt
>> *** Error code 1
> 
> You need to enable the dbus option for at-spi2-core.
> 
> Perhaps we should add a patch like the attached one, since this keeps
> coming up (untested).
> Thomas
> <gtk3.diff>

+.if !empty(PKG_BUILD_OPTIONS.gtk3:Mgtk3-atk-bridge) && empty(PKG_BUILD_OPTIONS.at-spi2-core:Mdbus)
+BROKEN=		"gtk3 with the gtk3-atk-bridge enabled needs at-spi2-core built with the dbus option."
+.endif

Is there a rationale for deciding which of BROKEN or PKG_FAIL_REASON
to use in this situation?