Re: asterisk woes: everything newer than 16 does not work

[Greg Troxel <gdt%lexort.com@localhost>]

Gavan fixed the sed expression in 19/21/22 so the xml is now ok, and
these packages are now usable.


With that fix, the tally is:

* ok

16, 19

* broken tcp listeners

18, 20, 21, 22

* ignored

13


I wonder about an alternative fix, USE_TOOLS+=gsed.  16 lacks the patch
but asks for gsed.

Overall my inclination is

  on Sunday, request a pullup of Gavan's commits

  next Friday (7 days from this mail), drop the patches below, and turn
  on USE_TOOLS+=gsed.  Patches are supposed to be documented and sent
  upstream, and these aren't.  Pulling in gsed seems better than a patch
  in terms of maintenance, cognitive burden, etc.   Objections are
  hereby solicited.


$ egrep TOOL.*gsed asterisk*/*; ls  -ld asterisk*/patches/patch-build__tools_mak*
asterisk16/Makefile:USE_TOOLS+=         gsed
-rw-r--r--  1 gdt  users  591 Feb 19  2024 asterisk18/patches/patch-build__tools_make__xml__documentation
-rw-r--r--  1 gdt  users  589 Jan 17 19:00 asterisk19/patches/patch-build__tools_make__xml__documentation
-rw-r--r--  1 gdt  users  664 Dec 15  2023 asterisk20/patches/patch-build__tools_make__xml__documentation
-rw-r--r--  1 gdt  users  589 Jan 17 19:00 asterisk21/patches/patch-build__tools_make__xml__documentation
-rw-r--r--  1 gdt  users  589 Jan 17 19:00 asterisk22/patches/patch-build__tools_make__xml__documentation

$ egrep '^\+.*SED.*space' asterisk*/patches/patch-build__tools_mak*
asterisk18/patches/patch-build__tools_make__xml__documentation:+                ${SED} -r "/^[[:space:]]*(<[?]xml|<.DOCTYPE|<.?docs)/d" "${i}" >> "${output_file}"
asterisk19/patches/patch-build__tools_make__xml__documentation:+                ${SED} -r "/^[[:space:]]*(<[?]xml|<.DOCTYPE|<.?docs)/d" "${i}" >> "${output_file}"
asterisk20/patches/patch-build__tools_make__xml__documentation:+                ${SED} -r "/^[:space:]*(<[?]xml|<.DOCTYPE|<.?docs)/d" "${i}" >> "${output_file}"
asterisk21/patches/patch-build__tools_make__xml__documentation:+                ${SED} -r "/^[[:space:]]*(<[?]xml|<.DOCTYPE|<.?docs)/d" "${i}" >> "${output_file}"
asterisk22/patches/patch-build__tools_make__xml__documentation:+                ${SED} -r "/^[[:space:]]*(<[?]xml|<.DOCTYPE|<.?docs)/d" "${i}" >> "${output_file}"