pkgsrc_2024Q1: graphics/darktable fails to build

[Dave Tyson <dtyson%anduin.org.uk@localhost>]

Just tried to build graphics/darktable under NetBSD-10.0 (amd64) from
pkgsrc_2024Q1.

It fails processing cameras.xsd

[ 13%] Checking validity of cameras.xml
/usr/pkgsrc/graphics/darktable/work/darktable-
4.4.2/src/external/rawspeed/data/cameras.xsd:194: element complexType:
Schemas parser error : complex type 'CFA2
Type': The content model is not determinist.
WXS schema /usr/pkgsrc/graphics/darktable/work/darktable-
4.4.2/src/external/rawspeed/data/cameras.xsd failed to compile
*** [lib/darktable/rawspeed/data/cameras.xml.touch] Error code 5

I couldn't see anything obviously wrong with the file so looked at the
corresponding file in the latest version of darktable (4.6.1) - this is
slightly different in the area of the error. Bearing in mind there are
warnings about mixing files from different version, I thought it worth
a try and so patched the file:

--- src/external/rawspeed/data/cameras.xsd.orig 2023-06-12
22:39:40.000000000 +0100
+++ src/external/rawspeed/data/cameras.xsd      2024-04-23
22:08:04.013029871 +0100
@@ -194,8 +194,7 @@
   <xs:complexType name="CFA2Type">
     <xs:sequence>
       <xs:choice>
-        <xs:element type="ColorRowType" name="ColorRow" minOccurs="2"
maxOccurs="2"/>
-        <xs:element type="ColorRowType" name="ColorRow" minOccurs="6"
maxOccurs="6"/>
+        <xs:element type="ColorRowType" name="ColorRow" minOccurs="2"
maxOccurs="6"/>
       </xs:choice>
     </xs:sequence>
     <xs:attribute type="CFA2TypeWidthType" name="width"
use="required"/>


This fixed the issue and the build completed. I did a quick check that
it could open canon raw files successfully, but didn't do any further
testing.


I did try to build darktable 4.6.1 but this failed linking as it could
not find 'uselocale'. It would appear NetBSD doesn't have this function
in libc. Linux, FreeBSD and OpenBSD all have it so maybe this should be
added - should I raise a PR?

Dave

-- 
=========================
Phone: 07805784357
GnuPG Fingerprint: 9D69D60DA2CB9869
=========================