Re: libreoffice build failed - hidden symbol referenced by DSO on netbsd-10 aarch64

["David H. Gutteridge" <david%gutteridge.ca@localhost>]

On Mon, 8 Apr 2024 at 18:26:18 +1000, Paul Ripke wrote:
> Error is:
>
> 2024-04-07-22:11:54: /usr/bin/ld: 
> /home/tmp/pkgwrk/misc/libreoffice/work/libreoffice-24.2.1.2/workdir/LinkTarget/Executable/bestreversemap: 
> hidden symbol `__aarch64_ldadd8_acq_rel' in 
> /usr/pkg/gcc12/lib/gcc/aarch64--netbsd/12.3.0/libgcc.a(ldadd_8_4.o) is 
> referenced by DSO
> 2024-04-07-22:11:54: /usr/bin/ld: final link failed: bad value
> 2024-04-07-22:11:54: collect2: error: ld returned 1 exit status
>
> Searching the internets, it appears the easiest fix is to add
> `-mno-outline-atomics` to compile opts. I have a build with this
> running now which has made it past the previous failure.
>
> --- a/misc/libreoffice/Makefile
> +++ b/misc/libreoffice/Makefile
> @@ -193,7 +193,7 @@ PTHREAD_OPTS+=              require
>
> HAS_CONFIGURE=         yes
>
> -CXXFLAGS.NetBSD+=      -DNO_CPLUSPLUS_ALLOCA
> +CXXFLAGS.NetBSD+=      -DNO_CPLUSPLUS_ALLOCA -mno-outline-atomics
>
> # Do not use /tmp, outside of WRKSRC.
> CONFIGURE_ENV+=                TMPDIR=${WRKSRC}/tmp

Thanks, I've applied that. (We do the same elsewhere in a few places in
pkgsrc already. It's only applicable for aarch64, so it's gone in a
bit differently than your patch.)

Regards,

Dave