Re: CVS commit: pkgsrc/security/openssh

[Tobias Nygren <tnn%NetBSD.org@localhost>]

On Mon, 6 Nov 2023 10:06:00 +0000
Jonathan Perkin <jperkin%pkgsrc.org@localhost> wrote:

> * On 2023-11-06 at 09:59 GMT, Thomas Klausner wrote:
> 
> >I wanted it enabled for macOS (works for me there) too. What is the
> >problem with enabling it in general?
> 
> https://us-central.manta.mnx.io/pkgsrc/public/reports/trunk/x86_64/20231102.1803/libfido2-1.13.0nb1/configure.log
> 
> I don't know what other platforms aren't supported.

libfido2's src/CMakeLists.txt is explicit about which platforms are supported:

elseif(APPLE)
        list(APPEND FIDO_SOURCES hid_osx.c)
elseif(CMAKE_SYSTEM_NAME STREQUAL "Linux")
        list(APPEND FIDO_SOURCES hid_linux.c hid_unix.c)
elseif(CMAKE_SYSTEM_NAME STREQUAL "NetBSD")
        list(APPEND FIDO_SOURCES hid_netbsd.c hid_unix.c)
elseif(CMAKE_SYSTEM_NAME STREQUAL "OpenBSD")
        list(APPEND FIDO_SOURCES hid_openbsd.c hid_unix.c)
elseif(CMAKE_SYSTEM_NAME STREQUAL "FreeBSD" OR
    CMAKE_SYSTEM_NAME STREQUAL "MidnightBSD")
        list(APPEND FIDO_SOURCES hid_freebsd.c hid_unix.c)

The obviously correct solution here is enable it for those platforms and those only.

-Tobias