net/nmap fails to build on netbsd-9 amd64

[Greg Troxel <gdt%lexort.com@localhost>]

using pkgsrc up to date an hour ago.

It looks like upstream is failing to follow POSIX by using CHAR_MAX
without limits.h, but there are so few includes that I feel I am missing
something in a twisty maze of config headers.

https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/limits.h.html


=> Bootstrap dependency digest>=20211023: found digest-20220214
===> Checking for vulnerabilities in nmap-7.94
===> Building for nmap-7.94
Compiling libnetutil
cd libnetutil && /usr/pkg/bin/gmake
Compiling liblinear
gmake[1]: Entering directory '/tmp/work/net/nmap/work/nmap-7.94/liblinear'
gmake[1]: 'liblinear.a' is up to date.
gmake[1]: Leaving directory '/tmp/work/net/nmap/work/nmap-7.94/liblinear'
Compiling libnbase
cd nbase && /usr/pkg/bin/gmake
c++ -c -I./liblinear -Ino/include -DNOLUA -I./libdnet-stripped/include -I/usr/pkg/include -I/usr/pkg/include -I/usr/include -I/usr/pkg/include -I/usr/include -I/usr/include -I./nbase -I./nsock/include -DHAVE_CONFIG_H -DNMAP_PLATFORM=\"x86_64--netbsd\" -DNMAPDATADIR=\"/usr/pkg/share/nmap\" -D_FORTIFY_SOURCE=2 -O2 -fPIC -D_FORTIFY_SOURCE=2 -I/usr/pkg/include -I/usr/include -Wall -fno-strict-aliasing   charpool.cc -o charpool.o
gmake[1]: Entering directory '/tmp/work/net/nmap/work/nmap-7.94/libnetutil'
gmake[1]: Nothing to be done for 'all'.
gmake[1]: Leaving directory '/tmp/work/net/nmap/work/nmap-7.94/libnetutil'
Compiling libdnet
gmake[1]: Entering directory '/tmp/work/net/nmap/work/nmap-7.94/libdnet-stripped'
gmake[1]: Entering directory '/tmp/work/net/nmap/work/nmap-7.94/nbase'
gmake[1]: Nothing to be done for 'all'.
gmake[1]: Leaving directory '/tmp/work/net/nmap/work/nmap-7.94/nbase'
c++ -c -I./liblinear -Ino/include -DNOLUA -I./libdnet-stripped/include -I/usr/pkg/include -I/usr/pkg/include -I/usr/include -I/usr/pkg/include -I/usr/include -I/usr/include -I./nbase -I./nsock/include -DHAVE_CONFIG_H -DNMAP_PLATFORM=\"x86_64--netbsd\" -DNMAPDATADIR=\"/usr/pkg/share/nmap\" -D_FORTIFY_SOURCE=2 -O2 -fPIC -D_FORTIFY_SOURCE=2 -I/usr/pkg/include -I/usr/include -Wall -fno-strict-aliasing   osscan.cc -o osscan.o
Making all in include
gmake[2]: Entering directory '/tmp/work/net/nmap/work/nmap-7.94/libdnet-stripped/include'
/usr/pkg/bin/gmake  all-recursive
c++ -c -I./liblinear -Ino/include -DNOLUA -I./libdnet-stripped/include -I/usr/pkg/include -I/usr/pkg/include -I/usr/include -I/usr/pkg/include -I/usr/include -I/usr/include -I./nbase -I./nsock/include -DHAVE_CONFIG_H -DNMAP_PLATFORM=\"x86_64--netbsd\" -DNMAPDATADIR=\"/usr/pkg/share/nmap\" -D_FORTIFY_SOURCE=2 -O2 -fPIC -D_FORTIFY_SOURCE=2 -I/usr/pkg/include -I/usr/include -Wall -fno-strict-aliasing   output.cc -o output.o
gmake[3]: Entering directory '/tmp/work/net/nmap/work/nmap-7.94/libdnet-stripped/include'
c++ -c -I./liblinear -Ino/include -DNOLUA -I./libdnet-stripped/include -I/usr/pkg/include -I/usr/pkg/include -I/usr/include -I/usr/pkg/include -I/usr/include -I/usr/include -I./nbase -I./nsock/include -DHAVE_CONFIG_H -DNMAP_PLATFORM=\"x86_64--netbsd\" -DNMAPDATADIR=\"/usr/pkg/share/nmap\" -D_FORTIFY_SOURCE=2 -O2 -fPIC -D_FORTIFY_SOURCE=2 -I/usr/pkg/include -I/usr/include -Wall -fno-strict-aliasing   payload.cc -o payload.o
Making all in dnet
gmake[4]: Entering directory '/tmp/work/net/nmap/work/nmap-7.94/libdnet-stripped/include/dnet'
gmake[4]: Nothing to be done for 'all'.
gmake[4]: Leaving directory '/tmp/work/net/nmap/work/nmap-7.94/libdnet-stripped/include/dnet'
gmake[4]: Entering directory '/tmp/work/net/nmap/work/nmap-7.94/libdnet-stripped/include'
gmake[4]: Leaving directory '/tmp/work/net/nmap/work/nmap-7.94/libdnet-stripped/include'
gmake[3]: Leaving directory '/tmp/work/net/nmap/work/nmap-7.94/libdnet-stripped/include'
gmake[2]: Leaving directory '/tmp/work/net/nmap/work/nmap-7.94/libdnet-stripped/include'
Making all in src
gmake[2]: Entering directory '/tmp/work/net/nmap/work/nmap-7.94/libdnet-stripped/src'
gmake[2]: Nothing to be done for 'all'.
gmake[2]: Leaving directory '/tmp/work/net/nmap/work/nmap-7.94/libdnet-stripped/src'
gmake[2]: Entering directory '/tmp/work/net/nmap/work/nmap-7.94/libdnet-stripped'
gmake[2]: Nothing to be done for 'all-am'.
gmake[2]: Leaving directory '/tmp/work/net/nmap/work/nmap-7.94/libdnet-stripped'
gmake[1]: Leaving directory '/tmp/work/net/nmap/work/nmap-7.94/libdnet-stripped'
c++ -c -I./liblinear -Ino/include -DNOLUA -I./libdnet-stripped/include -I/usr/pkg/include -I/usr/pkg/include -I/usr/include -I/usr/pkg/include -I/usr/include -I/usr/include -I./nbase -I./nsock/include -DHAVE_CONFIG_H -DNMAP_PLATFORM=\"x86_64--netbsd\" -DNMAPDATADIR=\"/usr/pkg/share/nmap\" -D_FORTIFY_SOURCE=2 -O2 -fPIC -D_FORTIFY_SOURCE=2 -I/usr/pkg/include -I/usr/include -Wall -fno-strict-aliasing   portlist.cc -o portlist.o
charpool.cc:95:17: error: 'CHAR_MAX' was not declared in this scope
   char table[2*(CHAR_MAX + 1)];
                 ^~~~~~~~
charpool.cc:95:17: note: suggested alternative: 'WCHAR_MAX'
   char table[2*(CHAR_MAX + 1)];
                 ^~~~~~~~
                 WCHAR_MAX
charpool.cc: In constructor 'StrTable::StrTable()':
charpool.cc:88:12: error: 'table' was not declared in this scope
     memset(table, 0, sizeof(table));
            ^~~~~
charpool.cc:88:12: note: suggested alternative: 'mutable'
     memset(table, 0, sizeof(table));
            ^~~~~
            mutable
charpool.cc:89:26: error: 'CHAR_MAX' was not declared in this scope
     for (int i = 1; i <= CHAR_MAX; i++) {
                          ^~~~~~~~
charpool.cc:89:26: note: suggested alternative: 'WCHAR_MAX'
     for (int i = 1; i <= CHAR_MAX; i++) {
                          ^~~~~~~~
                          WCHAR_MAX
charpool.cc: In member function 'const char* StrTable::get(char)':
charpool.cc:93:53: error: 'table' was not declared in this scope
   const char *get(char c) { assert(c >= 0); return &table[c*2]; }
                                                     ^~~~~
charpool.cc:93:53: note: suggested alternative: 'mutable'
   const char *get(char c) { assert(c >= 0); return &table[c*2]; }
                                                     ^~~~~
                                                     mutable
gmake: *** [Makefile:119: charpool.o] Error 1
gmake: *** Waiting for unfinished jobs....
*** Error code 2

Stop.
make[1]: stopped in /home/n0/gdt/pkgsrc-current/pkgsrc/net/nmap
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/net/nmap