Re: xine can't show subtitles without fontconfig and freetype2

[adr <adr%SDF.ORG@localhost>]

On Sat, 8 Oct 2022, adr wrote:

> Date: Sat, 8 Oct 2022 22:34:43 +0000 (UTC)
> From: adr <adr%SDF.ORG@localhost>
> To: pkgsrc-users%netbsd.org@localhost
> Subject: xine can't show subtitles without fontconfig and freetype2
>
> Hi,
>
> xine can't show subtitles without fontconfig and freetype2.
> Freetype2 is included already in Makefile.common, but it must
> be set explicitly with --with-freetype. After including both, xine
> can now show subtitles even without setting separate.font_freetype.
>
> Any thoughts before sending a PR? Better to include --with-f... in 
> Makefile.common?
>
> Regards,
> adr.
>
> ===================================================================
> Index: Makefile
> ===================================================================
> RCS file: /cvsroot/pkgsrc/multimedia/xine-lib/Makefile,v
> retrieving revision 1.185
> diff -u -r1.185 Makefile
> --- Makefile	27 Sep 2022 20:58:21 -0000	1.185
> +++ Makefile	8 Oct 2022 22:26:43 -0000
> @@ -27,6 +27,8 @@
> .endif
>
> CONFIGURE_ARGS+=	--without-esound
> +CONFIGURE_ARGS+=	--with-fontconfig
> +CONFIGURE_ARGS+=	--with-freetype
>
> SUBST_CLASSES+=		oss
> SUBST_STAGE.oss=	pre-configure
> Index: Makefile.common
> ===================================================================
> RCS file: /cvsroot/pkgsrc/multimedia/xine-lib/Makefile.common,v
> retrieving revision 1.93
> diff -u -r1.93 Makefile.common
> --- Makefile.common	10 Aug 2022 23:25:07 -0000	1.93
> +++ Makefile.common	8 Oct 2022 22:26:43 -0000
> @@ -51,6 +51,7 @@
> 	cd ${WRKSRC} && autoconf
>
> .include "../../converters/libiconv/buildlink3.mk"
> +.include "../../fonts/fontconfig/buildlink3.mk"
> .include "../../graphics/freetype2/buildlink3.mk"
> .include "../../multimedia/ffmpeg4/buildlink3.mk"
> .include "../../mk/oss.buildlink3.mk"
> ===================================================================

I resent it with an attachment for your convenience.

? work
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/multimedia/xine-lib/Makefile,v
retrieving revision 1.185
diff -u -r1.185 Makefile
--- Makefile	27 Sep 2022 20:58:21 -0000	1.185
+++ Makefile	8 Oct 2022 22:26:43 -0000
@@ -27,6 +27,8 @@
 .endif
 
 CONFIGURE_ARGS+=	--without-esound
+CONFIGURE_ARGS+=	--with-fontconfig
+CONFIGURE_ARGS+=	--with-freetype
 
 SUBST_CLASSES+=		oss
 SUBST_STAGE.oss=	pre-configure
Index: Makefile.common
===================================================================
RCS file: /cvsroot/pkgsrc/multimedia/xine-lib/Makefile.common,v
retrieving revision 1.93
diff -u -r1.93 Makefile.common
--- Makefile.common	10 Aug 2022 23:25:07 -0000	1.93
+++ Makefile.common	8 Oct 2022 22:26:43 -0000
@@ -51,6 +51,7 @@
 	cd ${WRKSRC} && autoconf
 
 .include "../../converters/libiconv/buildlink3.mk"
+.include "../../fonts/fontconfig/buildlink3.mk"
 .include "../../graphics/freetype2/buildlink3.mk"
 .include "../../multimedia/ffmpeg4/buildlink3.mk"
 .include "../../mk/oss.buildlink3.mk"