pkgsrc-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: wip/py-num2words: Does converters sound the right category?



Am 15.07.2022 um 18:13 schrieb Mayuresh:
I have committed above package that converts numerical values into words.

Have written the category as "converters". If any other suggestions,
please share.

converters/Makefile says:
COMMENT= Document format and character code converters

But since that category also contain other converters, such as
p5-Convert-Color, that's fine.

I was thinking to add "devel" as a category, but since the package
provides a usable standalone program, that is not necessary.

DESCR says "at the moment". When was this moment? As a general rule,
don't use these relative time expressions anywhere in long-living
documentation. DESCR files are long-living, some of them don't get
updated for 20 years. Also, "a bit buggy" is as unspecific as it gets.
Since the project is hosted on GitHub, I guess they are documented as
GitHub issues. Having 73 issues for such a conceptually simple library
doesn't feel healthy at first sight.

I wonder why pkglint doesn't remark that WRKSRC is redundantly defined;
maybe it's because pkglint thinks that egg.mk modifies DISTNAME or
PKGNAME. GITHUB_PROJECT also looks redundant, and the package builds
fine if I remove these two variable assignments.

Maybe it would be possible to trim down the PLIST, at least for
*.{py,pyc,pyo}, as these are redundant, but that's not the job of your
package. :)

Roland


Home | Main Index | Thread Index | Old Index