Re: Odd random failures in nodejs 16.14.2 on 9.2-STABLE/amd64

[Mike Pumford <mpumford%mudcovered.org.uk@localhost>]

On 25/04/2022 23:22, Mike Pumford wrote:
> On 25/04/2022 23:11, Tobias Nygren wrote:
> > On Mon, 25 Apr 2022 22:59:29 +0100
> > Mike Pumford <mpumford%mudcovered.org.uk@localhost> wrote:
>
> > In these files:
> > nodejs/patches/patch-deps_v8_src_base_platform_platform-posix.cc
> > nodejs/patches/patch-deps_v8_src_heap_code-range.cc
> >
> > Report back if it helps.
> Those patches do look related to my issue. Kicked off a fresh build in 
> my package build chroot so once that's caught up I'll see if the changes 
> help.
After a bit of wrestling with package checksums I managed to do what you 
suggested and it looks like its worked. No more random failures running 
compilations and language servers.

For reference I've attached the changes I'm running with.

Mike

Index: lang/nodejs/distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/lang/nodejs/distinfo,v
retrieving revision 1.210
diff -u -r1.210 distinfo
--- lang/nodejs/distinfo	1 Apr 2022 18:41:02 -0000	1.210
+++ lang/nodejs/distinfo	2 May 2022 15:26:27 -0000
@@ -9,13 +9,13 @@
 SHA1 (patch-deps_uvwasi_include_wasi__serdes.h) = 32b85ef5824b96b35aba9280bbe7aa7899d9e5cf
 SHA1 (patch-deps_v8_src_base_platform_platform-freebsd.cc) = b47025f33d2991275bbcd15dbabb28900afab0e1
 SHA1 (patch-deps_v8_src_base_platform_platform-openbsd.cc) = 5e593879dbab095f99e82593272a0de91043f9a8
-SHA1 (patch-deps_v8_src_base_platform_platform-posix.cc) = f99d9bee3ce452dda41c9b2943ee16cebcbd0af3
+SHA1 (patch-deps_v8_src_base_platform_platform-posix.cc) = fb0ac6f40233ef3ae03143a97ea7628be00245a8
 SHA1 (patch-deps_v8_src_base_platform_semaphore.cc) = 802a95f1b1d131e0d85c1f99c659cc68b31ba2f6
 SHA1 (patch-deps_v8_src_base_strings.h) = 4d2b37491f2f74f1a573f8c1942790204e23a8bb
 SHA1 (patch-deps_v8_src_codegen_arm_cpu-arm.cc) = 84c75d61bc99c2ff9adeac3152f5b11ebb0e582b
 SHA1 (patch-deps_v8_src_common_globals.h) = 86637724864389f2b24251904de41669a2f00fbc
 SHA1 (patch-deps_v8_src_compiler_types.h) = 2a212282ab9d71e98ae56827fdb1d9778a6047a5
-SHA1 (patch-deps_v8_src_heap_code-range.cc) = dd240fd2f884bca7753d107919fd7d1e162235f0
+SHA1 (patch-deps_v8_src_heap_code-range.cc) = 60a6049ac33b0b60c998da09b2d272bec669214f
 SHA1 (patch-deps_v8_tools_run-llprof.sh) = 39aa3faf77492ef8dd35b411b7b0e4605b469af3
 SHA1 (patch-node.gyp) = 0c2e5ccae623a7b730490baf8d509fa550b63e03
 SHA1 (patch-node.gypi) = 4a104dba6c22702211009bc60a6be6f87554e2fa
Index: lang/nodejs/patches/patch-deps_v8_src_base_platform_platform-posix.cc
===================================================================
RCS file: /cvsroot/pkgsrc/lang/nodejs/patches/patch-deps_v8_src_base_platform_platform-posix.cc,v
retrieving revision 1.7
diff -u -r1.7 patch-deps_v8_src_base_platform_platform-posix.cc
--- lang/nodejs/patches/patch-deps_v8_src_base_platform_platform-posix.cc	24 Apr 2021 06:30:28 -0000	1.7
+++ lang/nodejs/patches/patch-deps_v8_src_base_platform_platform-posix.cc	2 May 2022 15:26:27 -0000
@@ -13,7 +13,7 @@
  #endif
  #endif
 +
-+#if V8_OS_NETBSD && V8_TARGET_ARCH_ARM64
++#if V8_OS_NETBSD
 +  raw_addr = 0;
 +#endif
    return reinterpret_cast<void*>(raw_addr);
Index: lang/nodejs/patches/patch-deps_v8_src_heap_code-range.cc
===================================================================
RCS file: /cvsroot/pkgsrc/lang/nodejs/patches/patch-deps_v8_src_heap_code-range.cc,v
retrieving revision 1.1
diff -u -r1.1 patch-deps_v8_src_heap_code-range.cc
--- lang/nodejs/patches/patch-deps_v8_src_heap_code-range.cc	1 Apr 2022 18:41:02 -0000	1.1
+++ lang/nodejs/patches/patch-deps_v8_src_heap_code-range.cc	2 May 2022 15:26:27 -0000
@@ -9,7 +9,7 @@
    base::MutexGuard guard(&mutex_);
    auto it = recently_freed_.find(code_range_size);
    if (it == recently_freed_.end() || it->second.empty()) {
-+#if V8_OS_NETBSD && V8_TARGET_ARCH_ARM64
++#if V8_OS_NETBSD
 +    return 0;
 +#else
      return FUNCTION_ADDR(&FunctionInStaticBinaryForAddressHint);