Re: "librsvg" build fails on netbsd-9/i386

[Tobias Nygren <tnn%NetBSD.org@localhost>]

On Sat, 26 Mar 2022 06:26:36 +0000
nia <nia%NetBSD.org@localhost> wrote:

> On Fri, Mar 25, 2022 at 12:30:02PM +0100, Tobias Nygren wrote:
> > The good news is the package works if the target assertion at this line
> > is simply commented out. So the proper fix should be trivial. The bad
> > news is the target looks like it /should/ be perfectly valid and I
> > don't have enough rust clue to decipher where it goes wrong. It might
> > be a bug in the system-deps and/or cfg_expr crates.
> 
> Looks like we're still patching in the i586 rust target (for NetBSD,
> other operating systems will accept a i586 target just fine),
> so upstream rust will probably only recognize i686.
> 
> Uncommenting the assertion is probably fine, it's silly.

In the cfg-expr crate there is a hard-coded list of known targets,
curated by the crate's upstream. I added i586 to there for librsvg.
This works, so I'll commit it for now.

Not sure how long-term viable this solution is. cfg-expr is
also used by x11/wired-notify but that builds without this fix
so with luck it is not universally needed.

It looks like aarch64_be could be similarily broken, but we can
deal with that later. Not important for 2022Q1.

-Tobias