Re: net/udns patch

[nia <nia%NetBSD.org@localhost>]

On Sat, Nov 14, 2020 at 07:11:39AM +0100, Martin Husemann wrote:
> On Fri, Nov 13, 2020 at 03:50:37PM -0600, Edgar Pettijohn wrote:
> >  #else
> > +#ifdef __OpenBSD__
> > +# include <sys/select.h>
> > +#endif
> >  # include <unistd.h>
> >  # include <sys/types.h>
> >  # include <sys/socket.h>
> 
> Is the #ifdef actually needed?
> 
> Martin

It's pretty unlikely pkgsrc even works on platforms without sys/select.h,
it's a standard header.

Adding ifdefs in cases like this can often be actively harmful to
portability:
https://github.com/ejurgensen/forked-daapd/pull/1114