Re: wm/xmonad

[Roland Illig <roland.illig%gmx.de@localhost>]

On 27.06.2020 19:33, Chavdar Ivanov wrote:
> Hi,
>
> Building wm/xmond apparently succeeds, there is no PLIST file in the
> package directory and the resulting tree contains essentially only
> the documentation and some Haskell libraries.

Same result for me.  I ran "HS_UPDATE_PLIST=yes bmake update", and the
generated PLIST indeed contains nothing in $PREFIX/bin.

The MESSAGE file has instructions to create a working window manager,
but the binary package does not contain the example Haskell program from
$WRKSRC/man/xmonad.hs.  That file would be useful in the binary package
as well.

After the current freeze, the package should be fixed to include as many
files from the distfile as possible, especially a complete working
example.  I attached the suggested patch.

Index: MESSAGE
===================================================================
RCS file: /cvsroot/pkgsrc/wm/xmonad/MESSAGE,v
retrieving revision 1.1
diff -u -p -T -r1.1 MESSAGE
--- MESSAGE	4 Jan 2016 12:45:36 -0000	1.1
+++ MESSAGE	27 Jun 2020 19:24:59 -0000
@@ -1,8 +1,8 @@
	===========================================================================
	# $NetBSD: MESSAGE,v 1.1 2016/01/04 12:45:36 szptvlfn Exp $
	
-	    1. create ~/.xmonad/xmonad.hs
-	    2. $ ghc --make ~/.xmonad/xmonad.hs
-	    3. add exec xmonad to .xinitrc
-	    4. add ~/.xmonad to your $PATH
+	1. cp ${PREFIX}/share/examples/xmonad/xmonad.hs ~/.xmonad/xmonad.hs
+	2. edit ~/.xmonad/xmonad.hs to your liking
+	3. ghc --make ~/.xmonad/xmonad.hs
+	4. add exec ~/.xmonad/xmonad to .xinitrc
	===========================================================================
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/wm/xmonad/Makefile,v
retrieving revision 1.13
diff -u -p -T -r1.13 Makefile
--- Makefile	11 Jan 2020 14:37:18 -0000	1.13
+++ Makefile	27 Jun 2020 19:24:59 -0000
@@ -2,6 +2,7 @@
	
	DISTNAME=	xmonad-0.15
	PKGNAME=	${DISTNAME}
+	PKGREVISION=	1
	CATEGORIES=	wm
	
	MAINTAINER=	esg%sdf.lonestar.org@localhost
@@ -21,10 +22,11 @@ SUBST_STAGE.2=		pre-configure
	SUBST_FILES.2=		xmonad.cabal
	SUBST_FILTER_CMD.2=	${TR} '+' \\n
	
-	INSTALLATION_DIRS+=	${PKGMANDIR}/man1
+	AUTO_MKDIRS=		yes
	
	post-install:
		${INSTALL_MAN} ${WRKSRC}/man/xmonad.1 ${DESTDIR}${PREFIX}/${PKGMANDIR}/man1
+		${INSTALL_DATA} ${WRKSRC}/man/xmonad.hs ${DESTDIR}${PREFIX}/share/examples/${PKGBASE}/
	
	.include "../../devel/hs-data-default/buildlink3.mk"
	.include "../../devel/hs-extensible-exceptions/buildlink3.mk"
Index: PLIST
===================================================================
RCS file: PLIST
diff -N PLIST
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ PLIST	27 Jun 2020 19:24:59 -0000
@@ -0,0 +1,74 @@
+	@comment $NetBSD$
+	${HS_IMPL}/Paths_xmonad.hi
+	${HS_IMPL}/Paths_xmonad.p_hi
+	${HS_IMPL}/XMonad.hi
+	${HS_IMPL}/XMonad.p_hi
+	${HS_IMPL}/XMonad/Config.hi
+	${HS_IMPL}/XMonad/Config.p_hi
+	${HS_IMPL}/XMonad/Core.hi
+	${HS_IMPL}/XMonad/Core.p_hi
+	${HS_IMPL}/XMonad/Layout.hi
+	${HS_IMPL}/XMonad/Layout.p_hi
+	${HS_IMPL}/XMonad/Main.hi
+	${HS_IMPL}/XMonad/Main.p_hi
+	${HS_IMPL}/XMonad/ManageHook.hi
+	${HS_IMPL}/XMonad/ManageHook.p_hi
+	${HS_IMPL}/XMonad/Operations.hi
+	${HS_IMPL}/XMonad/Operations.p_hi
+	${HS_IMPL}/XMonad/StackSet.hi
+	${HS_IMPL}/XMonad/StackSet.p_hi
+	${HS_IMPL}/libHS${HS_PKGID}.a
+	${HS_IMPL}/libHS${HS_PKGID}_p.a
+	${HS_INTF}/package-description
+	${HS_INTF}/package-id
+	man/man1/xmonad.1
+	${HS_DOCS}/LICENSE
+	${HS_DOCS}/html/XMonad-Config.html
+	${HS_DOCS}/html/XMonad-Core.html
+	${HS_DOCS}/html/XMonad-Layout.html
+	${HS_DOCS}/html/XMonad-Main.html
+	${HS_DOCS}/html/XMonad-ManageHook.html
+	${HS_DOCS}/html/XMonad-Operations.html
+	${HS_DOCS}/html/XMonad-StackSet.html
+	${HS_DOCS}/html/XMonad.html
+	${HS_DOCS}/html/doc-index-124.html
+	${HS_DOCS}/html/doc-index-45.html
+	${HS_DOCS}/html/doc-index-46.html
+	${HS_DOCS}/html/doc-index-60.html
+	${HS_DOCS}/html/doc-index-61.html
+	${HS_DOCS}/html/doc-index-95.html
+	${HS_DOCS}/html/doc-index-A.html
+	${HS_DOCS}/html/doc-index-All.html
+	${HS_DOCS}/html/doc-index-B.html
+	${HS_DOCS}/html/doc-index-C.html
+	${HS_DOCS}/html/doc-index-D.html
+	${HS_DOCS}/html/doc-index-E.html
+	${HS_DOCS}/html/doc-index-F.html
+	${HS_DOCS}/html/doc-index-G.html
+	${HS_DOCS}/html/doc-index-H.html
+	${HS_DOCS}/html/doc-index-I.html
+	${HS_DOCS}/html/doc-index-J.html
+	${HS_DOCS}/html/doc-index-K.html
+	${HS_DOCS}/html/doc-index-L.html
+	${HS_DOCS}/html/doc-index-M.html
+	${HS_DOCS}/html/doc-index-N.html
+	${HS_DOCS}/html/doc-index-O.html
+	${HS_DOCS}/html/doc-index-P.html
+	${HS_DOCS}/html/doc-index-Q.html
+	${HS_DOCS}/html/doc-index-R.html
+	${HS_DOCS}/html/doc-index-S.html
+	${HS_DOCS}/html/doc-index-T.html
+	${HS_DOCS}/html/doc-index-U.html
+	${HS_DOCS}/html/doc-index-V.html
+	${HS_DOCS}/html/doc-index-W.html
+	${HS_DOCS}/html/doc-index-X.html
+	${HS_DOCS}/html/doc-index-Z.html
+	${HS_DOCS}/html/doc-index.html
+	${HS_DOCS}/html/haddock-bundle.min.js
+	${HS_DOCS}/html/index.html
+	${HS_DOCS}/html/linuwial.css
+	${HS_DOCS}/html/meta.json
+	${HS_DOCS}/html/quick-jump.css
+	${HS_DOCS}/html/synopsis.png
+	${HS_DOCS}/html/xmonad.haddock
+	share/examples/xmonad/xmonad.hs