Re: Failure to build www/firefox

[Roland Illig <roland.illig%gmx.de@localhost>]

On 07.05.2020 21:06, Martin Husemann wrote:
> On Thu, May 07, 2020 at 07:55:20PM +0100, Mike Pumford wrote:
> > Just found this change to clang10 in the right timeframe that looks like it
> > might impact which libstdc++ we are getting:
> >
> > http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/lang/clang/Makefile.common.diff?r1=1.42&r2=1.43&only_with_tag=MAIN
> >
> > Just kicked off a build with that change backed out and see if it helps.
>
> I can tell you without waiting for the build results:
>
> with r1.42 I get SUBST_CLASES libcxx cmake, with r1.42 it is only cmake.
>
> This change is broken and we need to rebuild clang as well.

Oops, you're right. I accidentally removed a negation in the lower part.
That should have been != YES instead of == YES. I remember that I tested
a few combinations, but apparently not enough to catch this simple bug.

I'm fixing it.

Roland