Re: misc/stellarium build issue

[Adam <adam%netbsd.org@localhost>]

Which OS/version?

> Hi,
> 
> Trying to build misc/stellarium with pkgsrc updated some 5 days ago I got:
> ...
> [ 36%] Building CXX object
> src/CMakeFiles/stelMain.dir/core/StelLocationMgr.cpp.o
> /usr/pkgsrc/misc/stellarium/work/stellarium-0.19.3/src/core/StelLocationMgr.cpp:
> In member function 'virtual void LibGPSLookupHelper::query()':
> /usr/pkgsrc/misc/stellarium/work/stellarium-0.19.3/src/core/StelLocationMgr.cpp:134:23:
> error: no match for 'operator==' (operand types are 'timespec_t' {aka
> 'timespec'} and 'double')
>    if (newdata->online==0.0) // no device?
>        ~~~~~~~~~~~~~~~^~~~~
> In file included from /usr/pkg/qt5/include/QtCore/qstring.h:49,
>                 from /usr/pkg/qt5/include/QtCore/QString:1,
>                 from
> /usr/pkgsrc/misc/stellarium/work/stellarium-0.19.3/src/core/StelLocation.hpp:22,
>                 from
> /usr/pkgsrc/misc/stellarium/work/stellarium-0.19.3/src/core/StelLocationMgr.hpp:22,
>                 from
> /usr/pkgsrc/misc/stellarium/work/stellarium-0.19.3/src/core/StelLocationMgr.cpp:19:
> 
> If one comments out the offending if operator, it builds and
> apparently works; I haven't tested it with a GPS device, though.
> 
> 
> --- src/core/StelLocationMgr.cpp.ORIG     2020-01-30 10:29:08.179006416 +0000
> +++ src/core/StelLocationMgr.cpp        2020-01-30 09:45:44.686568835 +0000
> @@ -131,13 +131,13 @@
> //                             emit queryError("GPSD query: No Fix.");
> //                             return;
> //                     }
> -                       if (newdata->online==0.0) // no device?
> -                       {
> -                               // This can happen when unplugging the
> GPS while running Stellarium,
> -                               // or running gpsd with no GPS receiver.
> -                               emit queryError("GPS seems offline. No fix.");
> -                               return;
> -                       }
> +//                     if (newdata->online==0.0) // no device?
> +//                     {
> +//                             // This can happen when unplugging the
> GPS while running Stellarium,
> +//                             // or running gpsd with no GPS receiver.
> +//                             emit queryError("GPS seems offline. No fix.");
> +//                             return;
> +//                     }
> 
> 
>                        fixmode=newdata->fix.mode; // 0:not_seen,
> 1:no_fix, 2:2Dfix(no alt), 3:3Dfix(perfect)
> 
> Chavdar
> 
> -- 
> ----
>