Strange firefox build failure

[Chavdar Ivanov <ci4ic4%gmail.com@localhost>]

Hi,

A week ago I started pkg_rolling-replace (yes, it is still going...).
Firefox 71.0nb1 failed as for some reason libmozwayland.so was not
built - the 'make'stage succeeded, but 'make package' failed PLIST
check.

Being rather naughty, I updated firefox (the rolling replace was still
going on, I didn't interrupt it, I realize it is wrong with respect to
the consistency of pkgsrc). I then tried building it - now at 72.01.

A compilation failed midway -- uchar.h missing  -- so I had to:
...
  diff -u work/build/dist/include/mozilla/webgpu/ffi/wgpu_ffi_generated.h.ORIG
work/build/dist/include/mozilla/webgpu/ffi/wgpu_ffi_generated.h
--- work/build/dist/include/mozilla/webgpu/ffi/wgpu_ffi_generated.h.ORIG
 2020-01-11 12:18:45.218063425 +0000
+++ work/build/dist/include/mozilla/webgpu/ffi/wgpu_ffi_generated.h
 2020-01-11 09:52:08.784384061 +0000
@@ -19,7 +19,7 @@
 #include <stdbool.h>
 #include <stdint.h>
 #include <stdlib.h>
-#include <uchar.h>
+#include <unicode/uchar.h>

 typedef enum {
   WGPUPowerPreference_Default = 0,
...

Then the 'make' phase completed, but 'make package' again failed for
the same reason - missing libmozwayland.so . I haven't excluded
wayland in mk.conf. So to complete the package, I simply copied one of
the other .so files in the expected directory to libmozwayland.so and
it managed to create the package. The resulting firefox 72.01
apparently runs rather well for now, it no longer starts with a core
dump (but then works) as 71.0 used to do. Surely it will fail under
wayland, but at the moment I can't test it as the status_bar of
wm/velox gets into an uninterruptable loop for me.

Most likely I have had my cvs update of pkgsrc in the wrong moment,
but as the libmozwayland.so question may arise elsewhere, just
mentioning it.

Chavdar



-- 
----