Re: Pkg_comp bug?

[maya%NetBSD.org@localhost]

On Fri, Sep 20, 2019 at 10:22:40AM -0500, Robert Nestor wrote:
> Not sure if this is a bug, but things don’t seem to be working.
> 
> I’m installing NetBSD-9.0_BETA and wanted to install some packages.  Since binaries for the packages aren’t available yet, I tried setting up pkg_comp on this newly installed system to build the packages of interest to me.
> 
> Downloaded a current version of pkgsrc to the newly installed system.
> 
> Did a pkgsrc/bootstrap build along with pkgtools/mksandbox and pkgtool/pkg_comp.  That all worked.
> 
> Then did a setup for pkg_comp to build a limited set of packages in a Native configuration, and tried invoking it with “pkg_comp -c pkgsrc auto”.  This all worked under NetBSD-8.0 so I didn’t anticipate any problems, however the sandbox build failed with an error trying to do a tar extraction of base.tar.xz.  I tracked it down to a place in sandbox.subr where it adds an “e” option to the tar command when running under NetBSD.  Apparently this option used to specific that tar should bail on the first error it encounters, but that option doesn’t seem to exist in the version of tar that is installed with NetBSD-9.0.  Removing the option allowed the pkg_comp command to successfully build the sandbox.
> 
> Is this a bug?  Should a PR be filed?

Applied, thanks for the report!

Please validate I got it right :-)